Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct circleci workflow #2365

Merged
merged 2 commits into from Feb 17, 2022

Conversation

cades
Copy link
Contributor

@cades cades commented Feb 15, 2022

when I tried to apply example Circle CI config to my config.yml, I found it contains a YAML syntax error, which is fixed in d2bc910.

And in a2e6ff1, the circleci/node version is upgraded and an unnecessary step is removed.

cades added 2 commits Feb 15, 2022
and since node/default executor is already using lts version of cimg/node docker image, the `node/install` step is removed.

reference: https://circleci.com/developer/orbs/orb/circleci/node#executors-default
jobs:
release:
executor: node/default
steps:
- checkout
- node/install
Copy link
Member

@travi travi Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason we include this step is to encourage using the latest lts version of node when releasing, even if that is not the version used to verify the project. does removing this step still accomplish that goal? if not would including a comment make that goal more clear here?

Copy link
Contributor Author

@cades cades Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replying!

The reason why that step can be removed is, circleci/node's default executor already uses lts node docker image.

(There is a configurable tag, which defaults to 'lts')

Reference: https://circleci.com/developer/orbs/orb/circleci/node#executors-default

@cades cades requested a review from travi Feb 17, 2022
travi
travi approved these changes Feb 17, 2022
Copy link
Member

@travi travi left a comment

thanks!

@travi travi changed the title Correct circleci workflow docs: Correct circleci workflow Feb 17, 2022
@travi travi enabled auto-merge (squash) Feb 17, 2022
@travi travi merged commit b4bc191 into semantic-release:master Feb 17, 2022
6 checks passed
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🎉 This PR is included in version 19.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

morey-tech pushed a commit to ratehub/semantic-release that referenced this pull request Sep 12, 2022
adityahex27 pushed a commit to hextrust/semantic-release that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants