Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): disabled rules that dont apply to this project #2408

Merged
merged 1 commit into from Apr 2, 2022
Merged

Conversation

travi
Copy link
Member

@travi travi commented Apr 2, 2022

the performance and readability of reduce is not a concern in this project since maintainers are
familiar with the idiom and are iterating over small lists. the filter rule is disabled selectively
since the filter being identified is not Array.filter

closes #2403

the performance and readability of reduce is not a concern in this project since maintainers are
familiar with the idiom and are iterating over small lists. the filter rule is disabled selectively
since the filter being identified is not Array.filter

closes #2403
@travi travi requested a review from a team Apr 2, 2022
gr2m
gr2m approved these changes Apr 2, 2022
Copy link
Member

@gr2m gr2m left a comment

THANK YOU 🙇🏼

@gr2m gr2m merged commit ab45ab1 into master Apr 2, 2022
6 checks passed
@gr2m gr2m deleted the lint branch Apr 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🎉 This PR is included in version 19.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

morey-tech pushed a commit to ratehub/semantic-release that referenced this pull request Sep 12, 2022
…-release#2408)

the performance and readability of reduce is not a concern in this project since maintainers are
familiar with the idiom and are iterating over small lists. the filter rule is disabled selectively
since the filter being identified is not Array.filter

closes semantic-release#2403
adityahex27 pushed a commit to hextrust/semantic-release that referenced this pull request Oct 31, 2022
…-release#2408)

the performance and readability of reduce is not a concern in this project since maintainers are
familiar with the idiom and are iterating over small lists. the filter rule is disabled selectively
since the filter being identified is not Array.filter

closes semantic-release#2403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address xo linting errors
2 participants