Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log-repo): use the original form of the repo url to remove the need to mask credentials #2459

Merged
merged 1 commit into from Jun 9, 2022

Conversation

travi
Copy link
Member

@travi travi commented Jun 8, 2022

fixes #2449

@travi travi requested a review from a team Jun 8, 2022
gr2m
gr2m approved these changes Jun 8, 2022
@travi travi force-pushed the log-repo branch 3 times, most recently from 16c6630 to 08c749a Compare Jun 8, 2022
@travi
Copy link
Member Author

travi commented Jun 8, 2022

i have been unable to reproduce the test failures locally in either node v16 or v14

@travi
Copy link
Member Author

travi commented Jun 8, 2022

it looks like all of the failures are in test/integration.test.js. i wonder if something has changed with how that is able to execute on actions recently.

@gr2m
Copy link
Member

gr2m commented Jun 8, 2022

me neither :(

Anyone else has any luck?

@travi travi merged commit 58a226f into master Jun 9, 2022
5 checks passed
@travi travi deleted the log-repo branch Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🎉 This PR is included in version 19.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@travi
Copy link
Member Author

travi commented Jun 9, 2022

i dont have a great explanation, but i updated the lockfile for #2447 to get it passing and rebased this branch with the mainline after merging that PR to pickup those lockfile changes, which enabled this change to pass the build 🤷🏼

morey-tech pushed a commit to ratehub/semantic-release that referenced this pull request Sep 12, 2022
adityahex27 pushed a commit to hextrust/semantic-release that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credentials are revealed in log
2 participants