Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for major zero-style initial development #138

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mandrean
Copy link

commented May 9, 2019

This PR adds support for major zero as outlined in http://semver.org.

Basically, breaking changes bumps the minor component and all other changes bumps the patch. Major is kept at zero.

Fixes #137.

@mandrean mandrean force-pushed the mandrean:feat/support-major-zero branch from da5b622 to 60da068 May 9, 2019

@mandrean

This comment has been minimized.

Copy link
Author

commented May 9, 2019

Travis CI fails for some reason:
image

image

mandrean added some commits May 9, 2019

@mandrean

This comment has been minimized.

Copy link
Author

commented May 9, 2019

Ah I see. The test fixture for initial-release & write-mode assumes that it would go from 0.1.0 to 1.0.0.

I updated them to go from 0.0.0 to 0.1.0 & 0.1.0 to 0.2.0, respectively.

Tests are green now!

@mersinvald

This comment has been minimized.

Copy link

commented Jul 5, 2019

+1 for that, it's a natural improvement for Rust ecosystem

@matchai

matchai approved these changes Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.