From c236737473117a9b65216eff8a500251e8f73595 Mon Sep 17 00:00:00 2001 From: Denis Gukov Date: Mon, 6 Sep 2021 21:15:37 +0500 Subject: [PATCH] fix(fe): error message for invalid cron format --- api/projects/schedules.go | 4 ++-- api/schedules/pool.go | 5 ++++- web2/src/components/TemplateForm.vue | 6 ++++++ web2/src/views/project/Templates.vue | 2 +- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/api/projects/schedules.go b/api/projects/schedules.go index 602442e67..262f22a18 100644 --- a/api/projects/schedules.go +++ b/api/projects/schedules.go @@ -74,7 +74,7 @@ func AddSchedule(w http.ResponseWriter, r *http.Request) { err := schedules.ValidateCronFormat(schedule.CronFormat) if err != nil { helpers.WriteJSON(w, http.StatusBadRequest, map[string]string{ - "error": err.Error(), + "error": "Cron: " + err.Error(), }) return } @@ -133,7 +133,7 @@ func UpdateSchedule(w http.ResponseWriter, r *http.Request) { err := schedules.ValidateCronFormat(schedule.CronFormat) if err != nil { helpers.WriteJSON(w, http.StatusBadRequest, map[string]string{ - "error": err.Error(), + "error": "Cron: " + err.Error(), }) return } diff --git a/api/schedules/pool.go b/api/schedules/pool.go index 600d4f64f..696d8ad72 100644 --- a/api/schedules/pool.go +++ b/api/schedules/pool.go @@ -14,7 +14,10 @@ type ScheduleRunner struct { } func (r ScheduleRunner) Run() { - _, err := tasks.AddTaskToPool(r.Store, db.Task{}, nil, r.Schedule.ProjectID) + _, err := tasks.AddTaskToPool(r.Store, db.Task{ + TemplateID: r.Schedule.TemplateID, + ProjectID: r.Schedule.ProjectID, + }, nil, r.Schedule.ProjectID) if err != nil { log.Error(err) } diff --git a/web2/src/components/TemplateForm.vue b/web2/src/components/TemplateForm.vue index 9d6e10eca..03bed4aec 100644 --- a/web2/src/components/TemplateForm.vue +++ b/web2/src/components/TemplateForm.vue @@ -5,6 +5,12 @@ v-model="formValid" v-if="isLoaded" > + {{ formError }} +