Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new davinci model version #2491

Merged
merged 1 commit into from Jan 9, 2023
Merged

Conversation

byronvoorbach
Copy link
Member

What's being changed:

Adds support for version 002 and 003 to the OpenAI text2vec and support for 003 to OpenAI QA

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 66.44% // Head: 66.47% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (698f607) compared to base (530bf59).
Patch coverage: 97.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2491      +/-   ##
==========================================
+ Coverage   66.44%   66.47%   +0.03%     
==========================================
  Files         571      572       +1     
  Lines       58341    58359      +18     
==========================================
+ Hits        38762    38792      +30     
+ Misses      17200    17190      -10     
+ Partials     2379     2377       -2     
Flag Coverage Δ
integration 67.40% <ø> (+0.03%) ⬆️
unittests 53.21% <97.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/qna-openai/config/class_settings.go 80.64% <ø> (ø)
usecases/replica/replicator.go 87.83% <ø> (+2.74%) ⬆️
usecases/traverser/explorer.go 56.17% <0.00%> (ø)
usecases/replica/finder.go 96.20% <95.23%> (-0.23%) ⬇️
...dules/text2vec-openai/vectorizer/class_settings.go 18.62% <100.00%> (+4.12%) ⬆️
usecases/replica/coordinator.go 100.00% <100.00%> (ø)
usecases/replica/resolver.go 100.00% <100.00%> (ø)
usecases/schema/get.go 59.42% <0.00%> (-4.22%) ⬇️
usecases/traverser/grouper/merge_group.go 77.29% <0.00%> (-1.32%) ⬇️
usecases/sharding/state.go 75.45% <0.00%> (+0.45%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@byronvoorbach byronvoorbach changed the title GH-2488 - Add support for new davinci model version Add support for new davinci model version Jan 9, 2023
@byronvoorbach byronvoorbach changed the base branch from master to stable/v1.17 January 9, 2023 12:25
@antas-marcin antas-marcin merged commit 51915b9 into stable/v1.17 Jan 9, 2023
@antas-marcin antas-marcin deleted the gh-2488 branch January 9, 2023 13:30
@dirkkul dirkkul restored the gh-2488 branch February 15, 2023 10:11
@dirkkul dirkkul deleted the gh-2488 branch March 10, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants