New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some trivial changes in the doc, including RT #93027 #19

Merged
merged 1 commit into from Feb 27, 2015

Conversation

Projects
None yet
2 participants
@zhouzhen1
Contributor

zhouzhen1 commented Feb 19, 2015

Hi Marc, I just made some trivial changes in WithAPIv1_1.pod, which includes two links of the 1.1 doc, and fix for RT#93027(https://rt.cpan.org/Public/Bug/Display.html?id=93027)

Also enabled ssl option by default for Net::Twitter::Lite Net::Twitter::Lite::WithAPIv1_1 by the second commit.

@zhouzhen1 zhouzhen1 changed the title from Some trivial changes in the doc, including RT #93027. to Some trivial changes in the doc, including RT #93027, and enabling ssl by default Feb 26, 2015

@semifor

View changes

lib/Net/Twitter/Lite/WithAPIv1_1.pm Outdated
@@ -20,21 +20,11 @@ sub new {
my $class = shift;
my %options = @_;
# Twitter now requires SSL connections. Since Net::Twitter::Lite is used
# Twitter now requires SSL connections. Since Net::Twitter::Lite was used

This comment has been minimized.

@semifor

semifor Feb 26, 2015

Owner

I think the present tense, is, is still appropriate here. It may still be used for compatible services that don't requires SSL. I have no way of knowing, for sure, but that's why we went through a deprecation cycle and why ssl => 0 is still an option.

@zhouzhen1 zhouzhen1 changed the title from Some trivial changes in the doc, including RT #93027, and enabling ssl by default to Some trivial changes in the doc, including RT #93027 Feb 27, 2015

@zhouzhen1

This comment has been minimized.

Contributor

zhouzhen1 commented Feb 27, 2015

I see. I just rebased.

semifor pushed a commit that referenced this pull request Feb 27, 2015

Marc Mims
Merge pull request #19 from zhouzhen1/zhouzhen1/doc_patches
Some trivial changes in the doc, including RT #93027

@semifor semifor merged commit 68fedcc into semifor:master Feb 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment