Skip to content

Conversation

@tomcontileslie
Copy link
Collaborator

@tomcontileslie tomcontileslie commented Dec 9, 2020

This PR supersedes #673; I've started a new one to squash the current log of ~30 commits and have easier write access to the PR (I was previously submitting PRs to Murray's branch).

This PR is joint work with @james-d-mitchell, @MTWhyte and @reiniscirpons. It creates a new StrongSemilatticeOfSemigroups object initialised from a list of semigroups, a (meet-semilattice) digraph and a list of homomorphisms. Currently element enumeration, element comparison and multiplication is possible, which makes this a fully working Semigroups object, and it will be ready to merge as soon as it passes tests and review.

In future I will also be working off this branch to create additional features such as decomposition of certain types of completely regular semigroups into StrongSemilatticeOfSemigroups objects.

@james-d-mitchell james-d-mitchell added the new-feature A label for PRs that contain new features label Dec 19, 2020
@tomcontileslie
Copy link
Collaborator Author

Just realised that there is inconsistency in the documentation calling an operation UnderlyingStrongSemilatticeOfSemigroups when it is actually implemented as UnderlyingSemilatticeOfSemigroups. I'll fix this in the next few days.

@codecov-io
Copy link

codecov-io commented Dec 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@664af4a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #722   +/-   ##
=========================================
  Coverage          ?   96.53%           
=========================================
  Files             ?      160           
  Lines             ?    37792           
  Branches          ?        0           
=========================================
  Hits              ?    36482           
  Misses            ?     1310           
  Partials          ?        0           

Copy link
Collaborator

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this apart from some minor comments. One other comment is: have you checked that the documentation looks ok when viewed as text only?

@james-d-mitchell
Copy link
Collaborator

I think I'm ready to merge this now, any reason not to @tomcontileslie ?

@tomcontileslie
Copy link
Collaborator Author

tomcontileslie commented Mar 1, 2021

@james-d-mitchell I've just updated the tests since your review updated error messages printed to the console in the standard test suite. All clear for merge on my end. To answer your question on documentation, all seems to render fine when read from within the GAP interface.

@wilfwilson
Copy link
Collaborator

When this PR is ready to be merged, I suggest doing a squash-and-merge to tidy up the commit history (see #752 (comment)). Or, if @tomcontileslie is confident and knowledgeable enough with git to rewrite the history of this branch via an interactive rebase and then force push a cleaned up version, then go ahead.

@tomcontileslie tomcontileslie force-pushed the strong-semilattice-new branch 3 times, most recently from c46dc64 to 291bcea Compare March 2, 2021 21:01
@tomcontileslie
Copy link
Collaborator Author

@wilfwilson I've tidied up the history into three commits that show broad chronological progression (and each commit should pass tests). Let me know whether that works for you, I can always squash further.

tomcontileslie and others added 3 commits March 2, 2021 22:08
Initial progress on the Strong Semilattice of Semigroups project by James, Murray, Reinis, Tom.

* Create operations StrongSemilatticeOfSemigroups and SSSE, and
  underlying attribute retrieval

* Basic operations for SSS elements (comparison, multiplication)

* Testing and first draft of documentation

Co-authored-by: James D. Mitchell <jdm3@st-andrews.ac.uk>
Co-authored-by: Murray Whyte <42549861+MTWhyte@users.noreply.github.com>
Co-authored-by: Reinis Cirpons <rc234@st-andrews.ac.uk>
Co-authored-by: Murray Whyte <mw231@st-andrews.ac.uk>
* Grammar and spelling corrections in documentation

* Change StrongSemilatticeOfSemigroups ->
  UnderlyingSemilatticeOfSemigroups to retrieve underlying attribute
@tomcontileslie tomcontileslie force-pushed the strong-semilattice-new branch from 291bcea to 1f64425 Compare March 2, 2021 21:12
@wilfwilson
Copy link
Collaborator

Nice one!

@james-d-mitchell james-d-mitchell merged commit 8acb9ba into semigroups:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature A label for PRs that contain new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants