-
Notifications
You must be signed in to change notification settings - Fork 38
Strong Semilattice of Semigroups #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong Semilattice of Semigroups #722
Conversation
|
Just realised that there is inconsistency in the documentation calling an operation |
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=========================================
Coverage ? 96.53%
=========================================
Files ? 160
Lines ? 37792
Branches ? 0
=========================================
Hits ? 36482
Misses ? 1310
Partials ? 0 |
james-d-mitchell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this apart from some minor comments. One other comment is: have you checked that the documentation looks ok when viewed as text only?
|
I think I'm ready to merge this now, any reason not to @tomcontileslie ? |
|
@james-d-mitchell I've just updated the tests since your review updated error messages printed to the console in the standard test suite. All clear for merge on my end. To answer your question on documentation, all seems to render fine when read from within the GAP interface. |
|
When this PR is ready to be merged, I suggest doing a squash-and-merge to tidy up the commit history (see #752 (comment)). Or, if @tomcontileslie is confident and knowledgeable enough with |
c46dc64 to
291bcea
Compare
|
@wilfwilson I've tidied up the history into three commits that show broad chronological progression (and each commit should pass tests). Let me know whether that works for you, I can always squash further. |
Initial progress on the Strong Semilattice of Semigroups project by James, Murray, Reinis, Tom. * Create operations StrongSemilatticeOfSemigroups and SSSE, and underlying attribute retrieval * Basic operations for SSS elements (comparison, multiplication) * Testing and first draft of documentation Co-authored-by: James D. Mitchell <jdm3@st-andrews.ac.uk> Co-authored-by: Murray Whyte <42549861+MTWhyte@users.noreply.github.com> Co-authored-by: Reinis Cirpons <rc234@st-andrews.ac.uk> Co-authored-by: Murray Whyte <mw231@st-andrews.ac.uk>
* Grammar and spelling corrections in documentation * Change StrongSemilatticeOfSemigroups -> UnderlyingSemilatticeOfSemigroups to retrieve underlying attribute
291bcea to
1f64425
Compare
|
Nice one! |
This PR supersedes #673; I've started a new one to squash the current log of ~30 commits and have easier write access to the PR (I was previously submitting PRs to Murray's branch).
This PR is joint work with @james-d-mitchell, @MTWhyte and @reiniscirpons. It creates a new
StrongSemilatticeOfSemigroupsobject initialised from a list of semigroups, a (meet-semilattice) digraph and a list of homomorphisms. Currently element enumeration, element comparison and multiplication is possible, which makes this a fully working Semigroups object, and it will be ready to merge as soon as it passes tests and review.In future I will also be working off this branch to create additional features such as decomposition of certain types of completely regular semigroups into
StrongSemilatticeOfSemigroupsobjects.