Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO meta is output when **ALL** SEO for Custom Post Types is disabled #1069

Closed
wpsmort opened this issue Aug 9, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@wpsmort
Copy link
Member

commented Aug 9, 2017

Related to #1067

If you uncheck all post type and taxonomy boxes under Custom Post Type Settings and then disable SEO for Custom Post Types then SEO meta is still output in the source of posts and pages.

This also happens with categories and tags in Pro, specifically where you've previously added SEO meta in the Edit Term screen.

This has been a bug for a while now.

Steps to reproduce this:

  1. Go to General Settings > Custom Post Type Settings and uncheck all checkboxes and disable Advanced Options then click Update Options
  2. Go back to Custom Post Type Settings and set SEO for Custom Post Types to Disabled
  3. View any post or page and you should see SEO meta in the source code

To reproduce for categories or tags:

  1. Edit the Uncategorized category and add some SEO meta
  2. Follow the steps above then view the Uncategorized category and check the source code

This problem should go away when we remove the SEO for Custom Post Types option - Issue #68

@wpsmort wpsmort added the Bug label Aug 9, 2017

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2017

@wpsmort
I tested this with four different, fresh local test sites and a few versions of WordPress (ranging from 4.8.1 to 4.0) and All in One SEO Pack (ranging from 2.3.15.3 (FREE) to 2.0.0 (FREE) and 2.4.15.3 to 2.0.1 (PRO)) and it seems that this never worked for Posts/Pages, at least, that's what I'm experiencing.

free
starting from 2.0: meta description is outputted
starting from 2.2: meta title is now outputted as well

pro
starting from 2.0: meta description is outputted
starting from 2.3: meta title is now outputted as well

Regarding Tags/Categories:
The plugin doesn't output the meta title, but started outputting the meta description starting from 2.3.1.

Perhaps check this a second time before assigning this to the development team.

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2017

@arnaudbroes I checked this and confirm that this bug has been present since v2.0 when we added the Custom Post Type Settings section.

@wpsmort wpsmort removed their assignment Aug 14, 2017

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Nov 25, 2017

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2017

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2017

@contactashish13 All in One SEO Pack is still changing the theme's title tag.

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2017

@arnaudbroes I assume you mean the title tag of the page. I don't see the title being changed except for some special characters being suitably modified e.g. pipe being converted to

–

Can you please check if its not something else?

Also, I've added a change so that the meta tag is not shown on the AMP pages either.

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2017

@contactashish13 I double-checked, looks like it works. Might have been browser cache.
@michaeltorbert I tested this. Needs code review.

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 17, 2018

@michaeltorbert michaeltorbert added this to the 2.7 milestone Mar 22, 2018

@wpsmort wpsmort modified the milestones: 2.7, 2.8 May 15, 2018

@wpsmort wpsmort modified the milestones: 2.8, 2.6 May 22, 2018

@wpsmort wpsmort assigned contactashish13 and unassigned wpsmort May 22, 2018

@wpsmort wpsmort removed this from the 2.6 milestone May 22, 2018

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented May 22, 2018

@contactashish13 I tested this and the title tag and custom canonical URL are still output. I checked the AMP page and the title tag is output there too. See screenshots:

screen shot 2018-05-22 at 6 14 33 pm

screen shot 2018-05-22 at 6 14 48 pm

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 26, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 26, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 26, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2018

@wpsmort have addressed the above observations.

@wpsmort wpsmort removed the In Development label Oct 9, 2018

@wpsmort wpsmort added this to the 2.9 milestone Oct 9, 2018

michaeltorbert added a commit that referenced this issue Oct 9, 2018

SEO meta is output when SEO for Custom Post Types is disabled (#1379)
* SEO meta is output when SEO for Custom Post Types is disabled #1069

* codeclimate

* exclude meta from AMP pages

* PR comments

#1069 (comment)

* test case

@michaeltorbert michaeltorbert changed the title SEO meta is output when SEO for Custom Post Types is disabled SEO meta is output when **ALL** SEO for Custom Post Types is disabled Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.