Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect link for Edit SEO in Admin Bar on taxonomies #1071

Closed
wpsmort opened this issue Aug 9, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@wpsmort
Copy link
Member

commented Aug 9, 2017

When viewing a taxonomy such as a category or tag page, the Edit SEO link in the Admin Bar takes you to the latest post.

The correct behavior is:

Free - There should be no Edit SEO link in the Admin Bar (this is a Pro feature)
Pro - The link should take you to the Edit term page for the category, tag, etc.

@wpsmort wpsmort added the Bug label Aug 9, 2017

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2017

@wpsmort
I tested this with two different, fresh local test sites and a few versions of WordPress (ranging from 4.8.1 to 4.0) and All in One SEO Pack (ranging from 2.4.15.3 (PRO) to 2.3.0 (PRO)) and it seems that this behaviour has been there since the introduction of SEO for taxonomies such as Categories and Tags.

Furthermore, this link has been present even before SEO for Categories and Tags was launched, so this means the code was most likely never modified to go to the relevant category/tag page when clicked and just goes by default to the latest post. This link works correctly for both Pages/Posts.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

Previously, it was probably showing up everywhere.
Now, it should only show up on a post (of any type) or a taxonomy, and should link to the correct edit page (pro only).
For pro testing, just drop the changed file (or copy/paste the changed function) into the Pro plugin.

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2017

@michaeltorbert PR #1086 is tested and the correct Edit SEO links show for both free and Pro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.