Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Social Tab still shows up for post type - separately #1077

Closed
michaeltorbert opened this issue Aug 10, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@michaeltorbert
Copy link
Member

commented Aug 10, 2017

screen shot 2017-08-10 at 3 56 28 pm

screen shot 2017-08-10 at 3 58 09 pm

@wpsmort

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

@arnaudbroes I can now reliably reproduce this bug. Here are the steps to follow:

  1. On a new install of WordPress, install and activate AIOSEOP from the WP.org plugin repository
  2. Activate the Social Meta module in Feature Manager
  3. Edit a post and the problem should be visible

I can also reproduce this by resetting all settings in AIOSEOP to default and then activating the Social Meta module.

Can you confirm you can reproduce this and then track this down to the version and commit where this bug originated.

@arnaudbroes arnaudbroes added Bug and removed Initial Review labels Aug 17, 2017

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2017

@wpsmort
Thanks, that worked! Traced back to 2.3.14.
One of these commits (same as #1053 #1074 ) caused the issue:

56db40c
04184bb
eaf66d8
c50b65d
762f9e3

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2017

@wpsmort @arnaudbroes Can you determine exactly what the setting is that's breaking this? Maybe comparing two settings dumps... one that isn't broken with one that's broken but shouldn't be?

@wpsmort

This comment has been minimized.

Copy link
Member

commented Aug 17, 2017

@michaeltorbert The setting that breaks this is the Enable Facebook Meta for Post Types setting. This is caused because the checkboxes for Posts and Pages were unchecked by default in v2.3.14.

We've now fixed that bug (Issue #1053) in the 2.3.16 branch and I've confirmed that it also fixes this issue as well. I tested this by installing v2.3.14, confirmed the bug is present and then updated to 2.3.16 and confirmed the bug is no longer present.

@wpsmort wpsmort assigned michaeltorbert and unassigned amostajo Aug 17, 2017

@michaeltorbert michaeltorbert removed their assignment Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.