Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Sitemap - support external images #1264

Closed
michaeltorbert opened this issue Oct 4, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@michaeltorbert
Copy link
Member

commented Oct 4, 2017

We should add a filter (or option) to allow externally hosted images, such as those from a cdn.

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2017

@michaeltorbert one way could be to have an option to whitelist comma-separated CDNs/hosts. Maybe a filter is not required in that case.

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2017

@contactashish13 Either way we should have a filter, so that it can be programmatically done easily, say on large multisite installations for instance.
We'd need to discuss whether to add an option. Ideally we cut down on options, not add them so that it's a simpler interface. This *may be important enough to have an option though. @wpsmort Thoughts?

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 6, 2017

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

@michaeltorbert have added the filter. We can extend this in case an option is required later. PR: #1281

@michaeltorbert michaeltorbert modified the milestones: 2.4.3, 2.4.4 Nov 17, 2017

@wpsmort wpsmort modified the milestones: 2.4.4, 2.4.5 Jan 11, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jan 19, 2018

@michaeltorbert michaeltorbert modified the milestones: 2.4.5, 2.5 Jan 31, 2018

@wpsmort wpsmort changed the title support external images XML Sitemap - support external images Feb 6, 2018

@wpsmort

This comment has been minimized.

Copy link
Member

commented Feb 6, 2018

I have tested PR #1281 and confirmed this works. I used the filter and tested with external images and with images from the WordPress CDN (Photon in JetPack).

I think a filter should be sufficient and we do not need an option for this.

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2018

synced with master and resolved the conflicts.

@wpsmort

This comment has been minimized.

Copy link
Member

commented Feb 8, 2018

@contactashish13 There are still conflicts showing in PR #1281:

Conflicting files: tests/modules/sitemap/test-sitemap.php

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Feb 9, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2018

@wpsmort resolved these conflicts.

@wpsmort wpsmort assigned michaeltorbert and unassigned wpsmort Feb 13, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 17, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 17, 2018

michaeltorbert added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 20, 2018

michaeltorbert added a commit that referenced this issue Mar 20, 2018

support external images (#1281)
* support external images #1264

* test case

* codeclimate

* codeclimate

* support for php5.2 and below

* support for WP 4.0

* support for WP 4.3 and below

* remove more extraneous code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.