Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom posts bbPress not outputting tags in source code #1297

Closed
arnaudbroes opened this issue Oct 12, 2017 · 11 comments

Comments

Projects
None yet
4 participants
@arnaudbroes
Copy link
Contributor

commented Oct 12, 2017

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 12, 2017

This may be a duplicate of #202

@arnaudbroes

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2017

@michaeltorbert I've tested bbPress with All in One SEO Pack (starting from 2.0) and it seems that Replies have never been supported before. There's three different custom post types: Forums, Topics and Replies, and it's just that last one that doesn't output any meta tags at all. We should probably look into it and see what's going wrong there.

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2017

@michaeltorbert I tested this and I'm confused - Forums and Topics have their own pages i.e. can be viewed on their own page but Replies are a subset of the Topic and have no page of their own so I'm not sure if this can be supported. Example: the forum can be viewed http://wordpress-118694-338656.cloudwaysapps.com/forums/forum/ddddd/ and the topic http://wordpress-118694-338656.cloudwaysapps.com/forums/topic/tipoc/ and the reply is just a named anchor in the topic: http://wordpress-118694-338656.cloudwaysapps.com/forums/topic/tipoc/

@arnaudbroes

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2017

@contactashish13 Replies do get a page of their own, as you can see here for example:
http://wordpress-111082-347208.cloudwaysapps.com/forums/reply/23

Follow these steps:

  1. Add a new Forum
  2. Add a new Topic and mark the Forum page as parent
  3. View the topic and do a reply on it.
  4. Now go to Replies in the WordPress backend. You'll see something like this: "Reply to: XXXX".
    Now take a look at that post. You'll see that it gets its own URL and outputs different tags in the source code.
@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2017

@arnaudbroes The view link gives "http://wordpress-118694-338656.cloudwaysapps.com/forums/topic/tipoc/#post-18251" as the URL as you can see in the screenshot below

image

@arnaudbroes

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2017

@contactashish13
Go to the Edit Screen of the Reply and then click the URL above.
image
I'm not sure why the URL on the Replies directory is different.

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2017

@arnaudbroes got it!

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

@michaeltorbert I may have found the problem. The meta tags are being added by determining what type of content is being loaded. For this we use is_single(), is_category(), is_page() etc. methods. Replies are comments to topics so they do not qualify as is_single() even when their own single page is loaded. They are in fact identified by is_singular(). I can add support for this but I don't know what else could be inadvertently supported because of this change.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

@contactashish13
Do you have a recommendation?
What about if is_singular and some_way_of_checking_bbpress_replies_only()?

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2017

@michaeltorbert its a fine balance between tying the plugin tightly to bbpress by using its functions/hooks vs. keeping it generic. But maybe for the short term we can go with the first method. What do you suggest?

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 21, 2017

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2017

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 17, 2018

@wpsmort wpsmort assigned contactashish13 and unassigned wpsmort Mar 20, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 9, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 11, 2018

@michaeltorbert michaeltorbert added this to the 2.9 milestone Oct 11, 2018

michaeltorbert added a commit that referenced this issue Oct 12, 2018

Custom posts bbPress not outputting tags in source code (#1319)
* Custom posts bbPress not outputting tags in source code #1297

* codeclimate

* not showing keywords meta

#1319 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.