Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate Descriptions: Problem #1308

Closed
mobilapk opened this issue Oct 15, 2017 · 15 comments

Comments

Projects
None yet
6 participants
@mobilapk
Copy link

commented Oct 15, 2017

Everyone Merhabalar

I have been using all in seo for a long time. I noticed a problem today. The "Autogenerate Descriptions" feature is turned on in the settings;

image

But this feature works on some pages.

image

some pages do not work.

image

This plugin needs to be updated.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 15, 2017

Please provide steps to reproduce the issue.

@mobilapk

This comment has been minimized.

Copy link
Author

commented Oct 16, 2017

Which steps I will follow. The problem is already present.

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2017

@mobilapk
We need you to provide us with the exact steps to reproduce this issue.
We can't fix something that we aren't able to reproduce.

@mobilapk

This comment has been minimized.

Copy link
Author

commented Oct 17, 2017

I did nothing to create the problem. I have not changed for years, I noticed it a week ago.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

@mobilapk We have been unable to reproduce this issue. So that we can investigate further, you can submit your username and password to our secure form here: https://semperplugins.com/contact/submit-login-information/

@mobilapk

This comment has been minimized.

Copy link
Author

commented Oct 18, 2017

I sent the form and sent it. I added the bug address to the description.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 20, 2017

When an image is in the content, it breaks our scanning for the meta description.

content part 1
<img src="http://someurl.com/someimage.jpg" />
content part 2
results in meta description = "content part 1"

Interestingly,
content part 1
<img src="http://someurl.com/someimage.jpg" />
content part 2
<img src="http://someurl.com/someimage.jpg" />
content part 3
results in meta description = "content part 1 content part 3"

@mobilapk

This comment has been minimized.

Copy link
Author

commented Oct 20, 2017

is this a plug-in bug?

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 20, 2017

@michaeltorbert one potential problem appears to be https://github.com/semperfiwebdesign/all-in-one-seo-pack/blob/master/aioseop_class.php#L4916 where, i'm not sure why, the tags are being cleared only for php v5.2. This conditions has been introduced in 2.3.14.1 with this commit: ad49500#diff-4e533641bc4be27bca19bde1a2b60fe9

I cannot find a reason for adding this condition. If that version check is removed, it will correctly remove all tags.

  1. https://github.com/semperfiwebdesign/all-in-one-seo-pack/blob/master/aioseop_class.php#L4922 does not make much sense because wp_strip_all_tags will anyways do this.
@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 20, 2017

@contactashish13 I'm not sure, it was added for this issue: #933

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 22, 2017

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2017

@michaeltorbert PR: #1322

Even though I've tried to be careful to not tread on any of the previous changes, I feel this needs a fair bit of testing.

@wpsmort could you mention the kind of text that got removed when you were testing #932 for which changes were made in #933? It will help me generate the test case for that condition.

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2017

@contactashish13 best to ask questions for @wpsmort to me or Michael since he has broken his back and is unavailable for the time being. I'll check this and get back to you.

@semperfiwebdesign semperfiwebdesign deleted a comment from mobilapk Oct 22, 2017

@semperfiwebdesign semperfiwebdesign deleted a comment from mobilapk Oct 23, 2017

@semperfiwebdesign semperfiwebdesign deleted a comment from arnaudbroes Oct 23, 2017

@semperfiwebdesign semperfiwebdesign deleted a comment from mobilapk Oct 23, 2017

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 23, 2017

I've deleted the extraneous comments.

This is a development repository site, not a place for chit chat, or for user support. We do not provide release dates. Constantly asking questions and making these types of comments would only delay a release.

@semperfiwebdesign semperfiwebdesign locked and limited conversation to collaborators Oct 23, 2017

@wpsmort

This comment has been minimized.

Copy link
Member

commented Mar 20, 2018

Note: The bug reported here where autogenerated descriptions break when an image is present was fixed by #1402 in v2.4.4

@wpsmort wpsmort assigned amostajo and contactashish13 and unassigned wpsmort and amostajo Mar 20, 2018

@wpsmort wpsmort removed the Needs Testing label Mar 20, 2018

@wpsmort

This comment has been minimized.

Copy link
Member

commented Mar 20, 2018

@contactashish13 There is still a bug here.

I found that with the current version of AIOSEOP v2.4.6.1 and the code in your PR #1322, the auto generated meta description is not displayed in the Description field when an HTML special character appears in the excerpt or content and PHP 5.2 in running.

To reproduce this, add a special character such as &nbsp; or © in your excerpt or content where it will be picked up as part of the auto generated description.

screen shot 2018-03-20 at 6 34 10 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.