Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribers can see Notice regarding XML sitemap #1345

Closed
scottbuscemi opened this issue Nov 8, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@scottbuscemi
Copy link

commented Nov 8, 2017

screen shot 2017-11-07 at 10 47 20 pm

Subscribers who access the wp-admin dashboard can see the above notice regarding the XML Sitemap. This should only appear for those with admin privileges.

@EkoJR

This comment has been minimized.

Copy link
Member

commented Nov 23, 2017

I believe this is exclusive to the Pro Version.

@scottbuscemi

This comment has been minimized.

Copy link
Author

commented Nov 23, 2017

@EkoJR

This comment has been minimized.

Copy link
Member

commented Nov 23, 2017

Well, it is possible there is an added feature that requires a message if it fits a set of conditions.

@scottbuscemi

This comment has been minimized.

Copy link
Author

commented Nov 23, 2017

@EkoJR

This comment has been minimized.

Copy link
Member

commented Nov 23, 2017

Hmm, when working on the free version I didn't see code for it, but the pro version had it.

It could of been a recent add that I'm missing, but it could also be a database variable. Either way, I wanted to comment on it. Thank you for replying back as well.

Admin notices recently got some work done, and I'll take another look to see where this got added in the free version.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Nov 24, 2017

@EkoJR It was added in version 2.4.1 in #1225 and can be found at

__( 'Notice: To avoid problems with your XML Sitemap, we strongly recommend you enable Sitemap Indexes and set the Maximum Posts per Sitemap Page to 1000.', 'all-in-one-seo-pack' ),

@scottbuscemi Thank you for reporting this, we'll get it fixed.

@michaeltorbert michaeltorbert added this to the 2.4.4 milestone Nov 24, 2017

@michaeltorbert michaeltorbert removed their assignment Nov 24, 2017

EkoJR added a commit to EkoJR/all-in-one-seo-pack that referenced this issue Dec 22, 2017

@wpsmort wpsmort modified the milestones: 2.4.4, 2.4.5 Jan 11, 2018

@michaeltorbert michaeltorbert self-assigned this Jan 31, 2018

EkoJR added a commit to EkoJR/all-in-one-seo-pack that referenced this issue Feb 1, 2018

Fix Sitemap Notice from showing to non-admins semperfiwebdesign#1345
This uses the `aiosp_manage_seo` capability.

@michaeltorbert michaeltorbert assigned wpsmort and unassigned EkoJR Feb 1, 2018

michaeltorbert added a commit that referenced this issue Feb 13, 2018

Fix Sitemap Notice from showing to non-admins #1345 (#1540)
This uses the `aiosp_manage_seo` capability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.