Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct tags order according to Sitemap protocol #1371

Closed
arnaudbroes opened this issue Nov 18, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@arnaudbroes
Copy link
Contributor

commented Nov 18, 2017

See conversation with Kevin K via email.

We should consider whether we want to correct the tag order for our XML sitemaps.
Currently, the priority tag is outputted before the changefreq tag while it should be the opposite.
https://www.sitemaps.org/protocol.html

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Nov 18, 2017

Unless there's a reason not to I'd say we should. @wpsmort?

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Nov 18, 2017

Ok generally it is the last one, we'll have to look into why it's not. Maybe only for indexed?

correct: view-source:https://semperplugins.com/sitemap.xml
incorrect: view-source:https://www.healthfulpursuit.com/sitemap_meal_type.xml

@michaeltorbert michaeltorbert added this to the 2.5 milestone Nov 18, 2017

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Nov 25, 2017

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2017

@michaeltorbert you were right. It was a problem only in the indexed pages. Additionally, the image tag was in the wrong location; have fixed that as well.

PR: #1378

@arnaudbroes

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2017

@michaeltorbert I tested this. Needs code review.

@contactashish13 contactashish13 modified the milestones: 2.5, 2.4.4 Jan 3, 2018

@wpsmort wpsmort modified the milestones: 2.4.4, 2.4.5 Jan 11, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jan 22, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jan 26, 2018

@michaeltorbert michaeltorbert modified the milestones: 2.4.5, 2.4.6 Jan 31, 2018

@wpsmort wpsmort assigned contactashish13 and wpsmort and unassigned wpsmort Feb 12, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Feb 13, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

@wpsmort fixed this.

@michaeltorbert another example here of things that will not work below WP 4.4.0: 0879891#diff-40a66dc34e8447efd254bdc5dc41f04cR2707

We may need to hasten support for 4.5.0

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Feb 13, 2018

@contactashish13 We now don't support anything below 4.4. When you say hasten support for 4.5, do you mean not support below 4.5?

@michaeltorbert michaeltorbert modified the milestones: 2.4.6, 2.4.7 Mar 15, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 16, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 17, 2018

@wpsmort wpsmort removed their assignment Mar 19, 2018

@michaeltorbert michaeltorbert modified the milestones: 2.4.7, 2.5 Mar 19, 2018

michaeltorbert added a commit that referenced this issue Mar 19, 2018

Correct tags order according to Sitemap protocol (#1378)
* Correct tags order according to Sitemap protocol #1371

* test case

* sync with master

* added phpdoc comment

* sync with master

* support for all phphunit versions

* support for images only on PHPUnit 5.7

* correct tags for taxonomies

* sync

* < WP 4.4.0

* syntax error

* < WP 4.4.0

* added composer to specify phpunit version

* run composer on install

* call vendor phpunit

* phpunit global/local

* composer global/local

* composer install only when phpunit is local

* local/global

* do not delete file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.