Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Sitemap - Mandatory field causing settings not to save #1548

Closed
wpsmort opened this issue Feb 7, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@wpsmort
Copy link
Member

commented Feb 7, 2018

There was a bug with the code in PR #1364 that didn't show up when I was testing.

The bug is related to making the fields under Additional Pages mandatory. Now when you try to save any setting in the XML Sitemap module you get a popup notification to fill out the Page URL field under Additional Pages.

This needs to be fixed urgently as the code in PR #1364 has already been merged with our development branch in readiness for the next release. The warning message about mandatory fields under Additional Pages should only show when you click the Add URL button and not when you click the Update Sitemap button.

See screenshot below:

screen shot 2018-02-07 at 1 59 08 pm

@wpsmort wpsmort added this to the 2.4.5 milestone Feb 7, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Feb 8, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2018

@wpsmort have fixed this and created a PR against dev: #1549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.