Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title counter color off #1581

Closed
michaeltorbert opened this issue Feb 20, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@michaeltorbert
Copy link
Member

commented Feb 20, 2018

Reported here: https://wordpress.org/support/topic/something-is-wrong-with-counting-the-signs-in-the-title/

Previously, the color of the title counter in edit post would change from gray to yellow at x characters, and then to red at y characters.
It now starts at yellow.

This appears to have broken in 2.4.4.

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2018

@arnaudbroes Starting around 2.4.4, can you determine which commit broke this?

@michaeltorbert michaeltorbert added the Bug label Feb 20, 2018

arnaudbroes added a commit that referenced this issue Mar 16, 2018

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2018

@michaeltorbert this broke here f17df67 and I've already written and tested a tiny fix for it.

*You may want to rename the commit if you can.

arnaudbroes added a commit that referenced this issue Mar 21, 2018

Fixed character counter for title #1581 (revised)
Fixed code so that title character counter can revert back to yellow and grey when characters are removed.
Also switched expression according to Yoda conditions & WP code standards and changed '==' to '==='.

@michaeltorbert michaeltorbert added this to the 2.7 milestone Mar 22, 2018

@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2018

This should be fixed now with my latest commit and PR.

@michaeltorbert michaeltorbert modified the milestones: 2.7, 2.5 Mar 28, 2018

@wpsmort wpsmort modified the milestones: 2.5, 2.6 Mar 28, 2018

@wpsmort wpsmort modified the milestones: 2.6, 2.5 Mar 28, 2018

michaeltorbert added a commit that referenced this issue Mar 29, 2018

Fixed character counter for title & home title (#1581) (#1633)
* Fixed character counter for title #1581

* Fixed character counter for home title #1581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.