Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
FTP credentials required on every pageload bug #1774
This happens with some sites that have whatever filesystem issues (no suexec, incorrect permissions, not having FS_METHOD as direct, or whatever). (Reported by Eric in email)
For testing, we can force the issue by changing FS_Method to ftpsockets in wp-config.php
The problem is has_physical_file() may be getting called on every pageload, ultimately meaning request_filesystem_credentials() is getting called on every pageload.
Offhand I'd recommend something like this to move it out of the construct:
$dirname = AIOSEOP_PLUGIN_DIRNAME;
This will at least restrict it to the robots.txt options page... then we need to figure out where to go from there to not have it request filesystem credentials every time we want to access the filesystem. If we can't access it, we should fail gracefully.
In the sitemap module, it uses add_action( $this->prefix . 'settings_header'...