Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robots.txt - Add an Edit Rule feature #1820

Closed
wpsmort opened this issue Aug 6, 2018 · 3 comments

Comments

@wpsmort
Copy link
Member

commented Aug 6, 2018

Requested by Dorte by email today.

With the new Robots module you can add a rule and delete a rule but you can't edit an existing rule. We should look at adding this ability.

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

@wpsmort Correct me if I'm wrong, but isn't this easy to do by deleting a rule and then adding it again?

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2018

@contactashish13 Yes, but that's additional work for the user and this user has asked if we can add an edit rule feature. In this case, the user has a lot of rules which were imported in and would find it easier to be able to edit a specific rule than delete and replace it.

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Aug 8, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

@wpsmort PR: #1826

@michaeltorbert once you merge #1803 I will add test cases for this as well.

@wpsmort wpsmort removed the Needs Testing label Aug 13, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Aug 21, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Aug 27, 2018

@wpsmort wpsmort modified the milestones: 2.9, 2.8 Aug 27, 2018

@wpsmort wpsmort modified the milestones: 2.8, 2.9 Sep 7, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 12, 2018

@wpsmort wpsmort assigned contactashish13 and unassigned wpsmort Oct 8, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 9, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 10, 2018

michaeltorbert added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 11, 2018

michaeltorbert added a commit that referenced this issue Oct 11, 2018

Robots.txt - Add an Edit Rule feature #1820 (#1826)
* Robots.txt - Add an Edit Rule feature #1820

* multisite issue

#1826 (comment)

* test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.