Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Calling parse_str() without the result argument is deprecated" #1880

Closed
arnaudbroes opened this issue Sep 4, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@arnaudbroes
Copy link
Contributor

commented Sep 4, 2018

Reported on 9/4/2018 at 4:16 PM EST.
Error can be found at https://www.thebrooklandscars.co.uk/sitemap.xml.

@michaeltorbert, can you review this and confirm we just need to add a second, result argument in order to fix this?

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

That's correct, this is as of PHP 7.2 according to https://secure.php.net/manual/en/function.parse-str.php

@michaeltorbert michaeltorbert removed their assignment Sep 4, 2018

@arnaudbroes arnaudbroes added this to the 2.8 milestone Sep 5, 2018

@arnaudbroes

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2018

@EkoJR please take care of this before the next release if possible. Should be a quick fix.

@EkoJR

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

This problem only affects the Pro Version with the Video Sitemap feature.

In regards to the initial report, I've been unable to reproduce the exact same error, and the sitemap was still operating. Also, the variable was being set as null instead of throwing an error.

Tested on PHP 7.2.4

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

Closing in favor of the Pro issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.