Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded to this post dropdown (images) disappeared #1899

Closed
netinial opened this issue Sep 11, 2018 · 12 comments

Comments

Projects
None yet
5 participants
@netinial
Copy link

commented Sep 11, 2018

After Auto Update (2.8)
Uploaded to this post (images) disappeared

Pages or Posts
Click Add Media
From Media Library
Under
All Media Items
There should be Uploaded to this post.

I confirm that when I disabled AIOSEO from plugins it is appearing again.
False Screen
adsiz

True Screen
adsiz2

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 11, 2018

@netinial We're unable to reproduce this, can you send us your wp-admin information so we can log in and resolve the issue? https://semperplugins.com/contact/support-login-information/

@netinial

This comment has been minimized.

Copy link
Author

commented Sep 11, 2018

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 11, 2018

@netinial Thank you for the information. Unfortunately, logging in I'm still unable to easily determine the problem. Is it ok if I make a private temporary clone of your site for the purpose of debugging this issue?

@netinial

This comment has been minimized.

Copy link
Author

commented Sep 11, 2018

If there is no way. Ok.

@netinial

This comment has been minimized.

Copy link
Author

commented Sep 14, 2018

Dear Michael, This is almost 3 days and we still can not use our website to update pictures. (It shows all pictures instead of post's)

Since disabling is not good option.

Would you please let us know are there any update?

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

@netinial When there are updates, you'll know on this page. Asking if there are any updates will only serve to slow development.

@michaeltorbert michaeltorbert added this to the 2.9 milestone Sep 14, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 14, 2018

@michaeltorbert michaeltorbert changed the title After Auto Update (2.8) Uploaded to this post (images) disappeared Uploaded to this post dropdown (images) disappeared Sep 15, 2018

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 15, 2018

When testing, we need to determine conclusively whether we introduced this in 2.8. If so, we need a point release (2.8.1) rather than wait for 2.9.

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2018

That line of code (contactashish13@968b189#diff-604ad90165044b2b600ad4f4148dfacaL1771) seems to be there for the last 2 years so I doubt it was introduced in 2.8.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 15, 2018

@contactashish13 You are correct that this particular line of code isn't new. However, we still need to test if the bug itself is new and was caused by other code that was introduced in 2.8, or whether the bug is pre-existing.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 15, 2018

I've confirmed that the bug does not exist in 2.7.3.
@arnaudbroes Can you figure out which commit caused it?

Steps to reproduce:

Install AIOSEOP.
Install the active3 theme.
Create new post, add media, change tab to "media library," then "Uploaded to this post" is missing.

(The active3 theme is in our private slack)

@semperfiwebdesign semperfiwebdesign deleted a comment from netinial Sep 15, 2018

@EkoJR

This comment has been minimized.

Copy link
Member

commented Sep 24, 2018

Thanks to a comment @contactashish13 made, I've isolated the issue to a recent change that was made on Line 3679 add_action( 'admin_enqueue_scripts', array( $this, 'admin_enqueue_scripts' ) ); d6358e9#diff-4e533641bc4be27bca19bde1a2b60fe9R3679

I challenged this against PR #1935 ( Changing to admin_enqueue_scripts ) which cleans up some of the enqueueing, and it does resolve this issue as well.

@EkoJR EkoJR self-assigned this Sep 25, 2018

@wpsmort

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

This is resolved in the v2.9 release.

@wpsmort wpsmort closed this Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.