Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Custom Post Type Settings - Empty title format fields #226

Closed
wpsmort opened this issue Apr 20, 2016 · 9 comments

Comments

Projects
None yet
3 participants
@wpsmort
Copy link
Member

commented Apr 20, 2016

There are two bugs in All in One SEO > General Settings > Custom Post Type Settings as follows:

1). The checkboxes for custom post types such as Products do not appear until you click Update Options. See screenshot below:

screen shot 2016-04-20 at 4 14 41 pm

2). The Title Format fields for custom post types such as Products are empty. This happens when you uncheck all settings and disable SEO for Custom Post Types then click away to a different screen, go back and recheck everything.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Apr 24, 2016

@wpsmort Was this fixed?

@michaeltorbert michaeltorbert modified the milestones: 2.3.5, 2.3.4.2 Apr 28, 2016

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2016

@michaeltorbert I have tested this with the latest version from the Dev branch and can confirm that the second bug still exists.

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2016

This is related to issue #68

@wpsmort wpsmort modified the milestones: 2.3.6, 2.3.5 Jun 13, 2016

@wpsmort wpsmort modified the milestones: 2.3.7, 2.3.6 Jun 22, 2016

@wpsmort wpsmort modified the milestones: 2.3.9, 2.3.7 Jul 8, 2016

@wpsmort wpsmort removed this from the 2.3.9 milestone Jul 18, 2016

@wpsmort wpsmort modified the milestones: 2.3.12.2, 2.3.13 Mar 22, 2017

@wpsmort wpsmort modified the milestones: 2.3.13, 2.3.14 May 31, 2017

@wpsmort wpsmort modified the milestones: 2.3.14, 2.3.15 Jun 30, 2017

@wpsmort wpsmort modified the milestones: 2.3.17, 2.3.16 Aug 9, 2017

@wpsmort wpsmort modified the milestones: 2.3.17, 2.5 Sep 5, 2017

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2018

@wpsmort I was unable to replicate the second bug. Can you please mention the steps I need to follow?

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2018

@contactashish13 Here are the steps to reproduce:

  1. Start with a new install of WordPress, AIOSEOP and WooCommerce. Make sure you have a product in WooCommerce.
  2. Go to All in One SEO > Custom Post Type Settings and uncheck all post types and then disable SEO for Custom Post Types
  3. Click away to any other screen in WP Admin
  4. Go back to All in One SEO > Custom Post Type Settings, enable SEO for Custom Post Types and check the post types for Products. Enable the Advanced Options and the check the Custom Titles box
  5. Click Update Options
  6. Now scroll back down to Custom Post Type Settings and you'll see that the Product Title Format field is blank. It should contain the text %post_title% | %blog_title%

See screenshot.

screen shot 2018-01-15 at 1 30 29 pm

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

@wpsmort While trying to fix this, this seemed to fix itself. It could be a problem with my (and consequently your) cache. In the below steps, 4a is what I was trying to accomplish and it already seems to be present. Can you please clear your cache and confirm this?

  1. Start with a new install of WordPress, AIOSEOP and WooCommerce. Make sure you have a product in WooCommerce.
  2. Go to All in One SEO > Custom Post Type Settings and uncheck all post types and then disable SEO for Custom Post Types
  3. Click away to any other screen in WP Admin
  4. Go back to All in One SEO > Custom Post Type Settings, enable SEO for Custom Post Types and check the post types for Products. Enable the Advanced Options and the check the Custom Titles box
    4a. This automatically shows the product title format field populated with %post_title% | %blog_title%.
  5. Click Update Options
  6. Now scroll back down to Custom Post Type Settings and you'll see that the Product Title Format field is not blank.
@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2018

@contactashish13 I am still able to reproduce this on a brand new local install in Chrome incognito. Here's a video of the problem - http://stevemortiboy.com/w5vnuhsjdkflgh45t/testing-issue-226.mov

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Feb 10, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

@wpsmort

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2018

PR #1553 is tested and is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.