Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce upgrade notice won't go away when clicking "no thanks" or close #2556

Closed
michaeltorbert opened this issue Jun 4, 2019 · 9 comments

Comments

Projects
None yet
5 participants
@michaeltorbert
Copy link
Member

commented Jun 4, 2019

Reported here: https://wordpress.org/support/topic/warning-msg-asking-to-upgrade-annoying

To Reproduce

This will need 2 users. 1 as the main admin, the other as an Editor.

  1. Go to Settings > Reading and enable "Discourage search engines from indexing this site" to trigger blog_public_disabled.
  2. Browse admin as the site admin to set WC notice.
  3. With notice displayed, click 'No thanks' to delay notice.
  4. In a different browser (or log out and log in as editor), browse site as an Editor. (the bug would trigger a reset)
  5. Go back other user, and browse as site admin. Notice displays when it should not appear.
@arnaudbroes

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

I was not able to reproduce this.

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

We'll need to investigate someone's site who is experiencing the problem. Anyone reading this can contact us directly at https://semperplugins.com/contact/
Where it asks for a "license key" just paste this issue's URL.

@Justabandit

This comment has been minimized.

Copy link

commented Jun 5, 2019

Whats the resolution to this apart from you closing opened issues

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

@Justabandit We're not simply closing open issues. You opened a duplicate issue.
The resolution to this is in the merged PR for 3.0.2 linked on this issue.

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

https://wordpress.org/support/topic/upgrade-nag-message-for-woocommerce-users/#post-11609995

Reported here that the problem is still there.
Another reported it went away after two clicks.
Another person has reported clearing the WP Fastest Cache made it go away for two clicks, then came back.

@michaeltorbert michaeltorbert reopened this Jun 6, 2019

@michaeltorbert michaeltorbert modified the milestones: 3.0.2, 3.0.3 Jun 6, 2019

@wpsmort

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

I had a services customer email yesterday to report this. He's not agreed to allow us access to his site. However, he reported that the notice was gone last night but didn't say what he did to get rid of it.

This morning he emailed to say that the notice is back on WooCommerce screens but gone from Jetpack screens. He had dismissed the notice on the Jetpack Stats screen by clicking the X. He's hosted on SiteGround and has cleared the SG cache.

I'm still trying to get him to give us access so we can take a look.

@michaeltorbert michaeltorbert removed this from the 3.0.3 milestone Jun 6, 2019

@EkoJR

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

I believe this may be occurring when multiple users have access to wp-admin, but don't have manage_options perms. Which causes the notice to deactivate, and to later be reactivated by site admin.

@EkoJR

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Confirmed this bug was being triggered by non-admins browsing the wp-admin side. Which would explain why it was difficult to reproduce.

It requires testing with 2 or more accounts, 1 as admin, and other(s) as non-admin.

@EkoJR EkoJR removed the Needs Reproducing label Jun 7, 2019

@michaeltorbert michaeltorbert added this to the 3.0.4 milestone Jun 7, 2019

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

One user just reported his site only has admins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.