Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Meta Module - OG Image not pulling in full size image #260

Open
kevinc08 opened this issue May 4, 2016 · 16 comments

Comments

Projects
None yet
8 participants
@kevinc08
Copy link

commented May 4, 2016

The OG image section in AIOSEO no longer pulls in the full size image but rather the large 1024x538 image (if the original image is bigger than that).

Previously, AIOSEO would just show the original full size image as one of the options in the image section.

https://scontent-hkg3-1.xx.fbcdn.net/hphotos-xtp1/v/t34.0-12/13152821_10153477949676837_522676256_n.png?oh=cbdbee3a560316cb4f817db447d614a3&oe=572CFEBA

I get around it by uploading a custom image and setting it to full size to use as my facebook OG image however this is tedious when I have to do a lot of posts.

Could you please change it back so AIOSEO pulls in the full size image please?

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented May 4, 2016

13152821_10153477949676837_522676256_n

@arnaudbroes

This comment was marked as outdated.

Copy link
Contributor

commented May 22, 2016

Looks like it's fixed. :-)

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented May 22, 2016

@arnaudbroes I don't think this has been addressed yet.

@wpsmort wpsmort changed the title OG Image not pulling in full size image Social Meta Module - OG Image not pulling in full size image Jun 22, 2016

@wpsmort

This comment has been minimized.

Copy link
Member

commented Jul 12, 2016

I have tested this and it only happens with images when you select either the Featured Image or the Attached Image options under All in One SEO > Social Meta > Image Settings > Select OG:Image Source (https://semperplugins.com/documentation/social-meta-module/#select-og-image-source).

To replicate this, follow these steps:

  1. In Social Meta module, set the OG:Image Source as either Featured Image or First Attached Image
  2. Create a new post and either attached a very large image or set it as the Featured Image.
  3. Check the source code for the og:image.

@wpsmort wpsmort removed the Initial Review label Jul 12, 2016

@michaeltorbert michaeltorbert added this to the 2.3.11 milestone Nov 1, 2016

@michaeltorbert michaeltorbert self-assigned this Nov 1, 2016

@michaeltorbert michaeltorbert modified the milestones: 2.3.12, 2.3.11 Nov 2, 2016

@michaeltorbert michaeltorbert modified the milestones: 2.3.13, 2.3.12 Mar 4, 2017

@wpsmort wpsmort modified the milestones: 2.3.12.2, 2.3.13 Mar 22, 2017

@wpsmort wpsmort modified the milestones: 2.3.13, 2.3.14 May 31, 2017

@wpsmort

This comment has been minimized.

Copy link
Member

commented Jun 12, 2017

@Garconis

This comment has been minimized.

Copy link

commented Jun 12, 2017

For now, I added:

add_filter( 'aioseop_thumbnail_size', 'change_aioseop_thumbnail_size' , 10, 1);
function change_aioseop_thumbnail_size( $size ){
    return 'full';
}

As documented here: https://semperplugins.com/documentation/opengraph-image-size/

But this should be fixed to at least offer an option to set the size, since having it use the "Large" size isn't ideal, nor expected.

@wpsmort

This comment has been minimized.

Copy link
Member

commented Mar 22, 2018

@contactashish13 I tested this and it still overriders the filter hook if you select either First Attached Image or First Available Image. The filter works fine if you select Featured Image.

@wpsmort wpsmort modified the milestones: 2.5, Future Release Mar 22, 2018

@wpsmort wpsmort removed the Needs Testing label Mar 22, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 20, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 20, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2018

@wpsmort have tested all combinations and they all work with the new commits.

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Sep 24, 2018

@michaeltorbert michaeltorbert modified the milestones: Future Release, 2.9 Oct 9, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 10, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 12, 2018

michaeltorbert added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 12, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 15, 2018

michaeltorbert added a commit that referenced this issue Oct 17, 2018

Social Meta Module - OG Image not pulling in full size image (#1461)
* Social Meta Module - OG Image not pulling in full size image #260

* PR comments

* PR comments

1) Using 3 filters: aioseop_attachment_size, aioseop_thumbnail_size and
post_thumbnail_size
2) image in content also being tested for being an attachment

* support for #1557

* PR comments

#260 (comment)

* test cases

* show full size image

* Update aioseop_opengraph.php

* PR comments

#1461 (comment)

* class name conflict

* moved methods

* PR comments

#1461 (comment)

* corrected test case

@michaeltorbert michaeltorbert removed this from the 2.9 milestone Oct 24, 2018

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

In 2.9 we introduced a fix for this, but then reverted in 2.9.1 due to performance issues.

Original PR #1461
Revert PR #2007
Revert Issue #1997

@michaeltorbert michaeltorbert added this to the 3.3 milestone Mar 13, 2019

@michaeltorbert michaeltorbert modified the milestones: 3.3, 3.4 Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.