Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wrong text domain and make “Version 3” localizable #2604

Closed
michaeltorbert opened this issue Jun 7, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@michaeltorbert
Copy link
Member

commented Jun 7, 2019

Reported: https://wordpress.org/support/topic/aioseop-l10n-issue

<h3><a href="https://semperplugins.com/all-in-one-seo-pack-3-0/" target="_blank"><?php echo esc_html( sprintf( __( "Check out what's new in our %s release post!", 'all_in_one_seo_pack' ), 'Version 3' ) ); ?></a></h3>

Original:
<h3><a href="https://semperplugins.com/all-in-one-seo-pack-3-0/" target="_blank"><?php echo esc_html( sprintf( __( "Check out what's new in our %s release post!", 'all_in_one_seo_pack' ), 'Version 3' ) ); ?></a></h3>

Implemented:
<h3><a href="https://semperplugins.com/all-in-one-seo-pack-3-0/" target="_blank"><?php echo esc_html( sprintf( __( "Check out what's new in our %s release post!", 'all-in-one-seo-pack' ), __( "Version 3", 'all-in-one-seo-pack' ) ) ); ?></a></h3>
Points: Correct wrong text domain and make “Version 3” localizable.

@michaeltorbert michaeltorbert added this to the 3.0.4 milestone Jun 7, 2019

michaeltorbert added a commit that referenced this issue Jun 7, 2019

michaeltorbert added a commit that referenced this issue Jun 7, 2019

Add and fix text domain for localizable strings (#2617)
* Fix text domain and make string localizable #2604

* Add text domain to strings #2605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.