Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google APIs are blocked in China #2607

Closed
michaeltorbert opened this issue Jun 7, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@michaeltorbert
Copy link
Member

commented Jun 7, 2019

Reported https://wordpress.org/support/topic/problems-with-new-version-6/

Google APIs are not reachable in china. in admin/aioseop_module_class.php, a googleapis jqueryui CDN was enqueued, as google was blocked in china for several years, this cdn makes every Chinese user take too long to open the admin page, even time out.
Consider pack the js file in the plugin files if you would?

We need to see when we started using Google APIs in order to determine if this needs to go out in 3.0.4.
Is there a reason why we aren't just shipping it?

@wpsmort

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

This was added in PR #2236 in this commit 1ab9b68

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

Ok so we can either load it from a different location, ship it, or use a built-in library
These are one that ship with WP https://developer.wordpress.org/reference/functions/wp_enqueue_script/#default-scripts-included-and-registered-by-wordpress

If we use ones built into WP, we need to check what version of WP they were first included with.

This tabs library is included https://jqueryui.com/tabs/

@EkoJR

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Those aren't scripts, those are styles. Most of which do not ship with WP.

@EkoJR

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

After 8 years....it's still an open issue. https://core.trac.wordpress.org/ticket/18909

@michaeltorbert michaeltorbert assigned arnaudbroes and unassigned EkoJR Jun 7, 2019

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

Test Microsoft's for China @arnaudbroes

@arnaudbroes arnaudbroes referenced this issue Jun 7, 2019

Merged

Change JQuery CDN to Microsoft #2618

3 of 3 tasks complete

@michaeltorbert michaeltorbert added Has PR and removed Initial Review labels Jun 7, 2019

michaeltorbert added a commit that referenced this issue Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.