Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Robots meta tag doesn't have correct closing tag #2876

Closed
Babene03 opened this issue Sep 6, 2019 · 5 comments

Comments

@Babene03
Copy link

commented Sep 6, 2019

In the Sourcecode of the Site, is no END Tag > from the Meta Tag

<meta name="robots" content="noindex,nofollow"

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

@Babene03
Thank you for reporting this. I've been able to reproduce this and have verified it is a bug.
I've assigned it to be fixed for the next major release.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

The problem is on

printf( '<meta name="robots" content="%s"', esc_attr( $robots_meta ) ) . " >\n";

from commit d76974e in 3.2.2.

Also, and this should probably be its own issue, we seem to be doing robots meta in two places. We should probably look into improving that.

$meta_string .= sprintf( '<meta name="robots" content="%s"', esc_attr( $robots_meta ) ) . " />\n";

@michaeltorbert michaeltorbert modified the milestones: 3.3, 3.2.6 Sep 6, 2019

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

As this was broken in 3.2.2, we should include it in 3.2.6.

@michaeltorbert michaeltorbert self-assigned this Sep 6, 2019

@michaeltorbert michaeltorbert changed the title No End Tag > Bug - Robots meta tag doesn't have correct closing tag Sep 6, 2019

@Babene03

This comment was marked as resolved.

Copy link
Author

commented Sep 6, 2019

I think the issue is

printf( "<meta name=\"robots\" content=\"%s\" >\n", esc_attr( $robots_meta ) );

I just focused on the line 4165, because the spelling is a bit different, so our solutions look a bit different

michaeltorbert added a commit that referenced this issue Sep 6, 2019
@michaeltorbert

This comment was marked as resolved.

Copy link
Member

commented Sep 6, 2019

@Babene03 Correct, which is also what I've posted above. ;)

@michaeltorbert michaeltorbert referenced this issue Sep 6, 2019
3 of 3 tasks complete

@arnaudbroes arnaudbroes added the Has PR label Sep 7, 2019

arnaudbroes added a commit that referenced this issue Sep 7, 2019
michaeltorbert added a commit that referenced this issue Sep 8, 2019
Add closing tag to robots meta (#2878)
* add closing tag to robots meta #2876

* Fix printing of closing tag & new line #2876
michaeltorbert added a commit that referenced this issue Sep 8, 2019
Add closing tag to robots meta (#2878)
* add closing tag to robots meta #2876

* Fix printing of closing tag & new line #2876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.