Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible canonical URL issue #437

Closed
michaeltorbert opened this issue Aug 17, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@michaeltorbert
Copy link
Member

commented Aug 17, 2016

Reported here: https://wordpress.org/support/topic/wrong-canonical-1?replies=1#post-8764788

_
_The WordPress has a bug, when page with non-existed subpage is a copy from main page.
Example: http://morrock.com/casino-games/32423 is the same as http://morrock.com/casino-games/

But the problem is that page is indexed by Google and is a duplicate of main page, because the canonical URL is http://morrock.com/casino-games/32423/.
Some websites fix this bug just replacing http://morrock.com/casino-games/*SUBPAGE*/ to http://morrock.com/casino-games/

404 page exist, so some pages like 222 or 333 always open same page. On all websites that use wordpress_
_

@wpsmort

This comment has been minimized.

Copy link
Member

commented Aug 22, 2016

The user fixed his issue specific issue by using the No Pagination for Canonical URLs option in AIOSEOP.

@wpsmort wpsmort closed this Aug 22, 2016

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

This can be reproduced by adding numbers at the end of a real page... https://semperplugins.com/all-in-one-seo-pack-pro-version/123/

It's not a "subpage" but WP apparently thinks it's a page with pagination and so in this example, the 123rd page.
We *should be able to detect that and set the appropriate canonical.

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

This actually may be a new issue. We need to test going back years if it always existed. There's a report that it worked in 2014.

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

This should also be tested not just for pages, but for posts, terms, etc.

@wpsmort

This comment has been minimized.

Copy link
Member

commented Aug 22, 2016

This worked in v2.0 and broke in v2.0.1.

We added the No Pagination for Canonical URLs option to "fix" this back in v2.2.2. We need to therefore remove this option once we've fixed the underlying bug.

@michaeltorbert

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2016

@wpsmort Is this supposed to be closed?

@michaeltorbert michaeltorbert removed their assignment Oct 8, 2016

@wpsmort wpsmort modified the milestones: 2.3.12, 2.3.10 Oct 10, 2016

@wpsmort wpsmort assigned michaeltorbert and unassigned wpsmort Oct 10, 2016

@wpsmort

This comment has been minimized.

Copy link
Member

commented Oct 10, 2016

@michaeltorbert No this should not be closed. I have changed this to the milestone for all canonical URL related issues.

@michaeltorbert michaeltorbert modified the milestones: 2.3.13, 2.3.12 Mar 4, 2017

@wpsmort wpsmort modified the milestones: 2.3.14, 2.3.13 Mar 22, 2017

@wpsmort wpsmort removed this from the 2.3.15 milestone Jul 11, 2017

@wpsmort wpsmort modified the milestones: 2.3.17, 2.3.16 Aug 9, 2017

@wpsmort wpsmort modified the milestones: 2.3.17, 2.5 Sep 5, 2017

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jan 15, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2018

PR: #1481

@wpsmort wpsmort assigned wpsmort and unassigned michaeltorbert Jan 15, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jan 26, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jan 26, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Feb 26, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 17, 2018

Merge remote-tracking branch 'refs/remotes/semperfiwebdesign/master' …
…into semperfiwebdesign#437

# Conflicts:
#	aioseop_class.php
#	tests/base/class-sitemap-test-base.php

@michaeltorbert michaeltorbert modified the milestones: 2.5, 2.6 Mar 22, 2018

@wpsmort wpsmort modified the milestones: 2.6, Future Release May 15, 2018

@wpsmort wpsmort assigned wpsmort and unassigned wpsmort May 15, 2018

@wpsmort wpsmort removed the Needs Testing label May 15, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jul 27, 2018

michaeltorbert added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Oct 9, 2018

@michaeltorbert michaeltorbert modified the milestones: Future Release, 2.9 Oct 9, 2018

michaeltorbert added a commit that referenced this issue Oct 12, 2018

possible canonical URL issue (#1481)
* possible canonical URL issue #437

* test case

incomplete, need to be looked into as post is not broken into pages

* correct test case

* unit tests fail when working together

* don't call _setUp by default

* paginated taxonomy archive

#1481 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.