Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Capitalize Tag and Search Titles option #530

Closed
wpsmort opened this issue Oct 3, 2016 · 3 comments
Closed

Remove the Capitalize Tag and Search Titles option #530

wpsmort opened this issue Oct 3, 2016 · 3 comments
Milestone

Comments

@wpsmort
Copy link

wpsmort commented Oct 3, 2016

We should remove this option and replace it with a filter hook.

We should respect the current setting.

@wpsmort
Copy link
Author

wpsmort commented Aug 1, 2017

We discussed this today and decided to remove all functionality related to capitalizing tag titles and search titles.

We'll be doing the same for capitalizing category titles (Issue #1006).

@michaeltorbert
Copy link
Contributor

michaeltorbert commented Aug 1, 2017

We'll also need to update the documentation. Code that can achieve much of the same thing:

add_filter('aioseop_title','change_seo_title', 10, 1); function change_seo_title( $title ){ static $charset = null; if ( $charset == null ) { $charset = get_bloginfo( 'charset' ); } if ( function_exists( 'mb_convert_case' ) ) { // Breaks for acronymns like SEO. $mytitle = mb_convert_case( $title, MB_CASE_TITLE, $charset ); } else { $mytitle = ucwords( $title ); } $title['title'] = $mytitle; return $title; }

*I'm not sure why this is so ugly.

Another example is:

add_filter(_ 'aioseop_title', 'aioseop_capitalize_title', 10, 1);

function aioseop_capitalize_title( $title ){
/*
* If you want to only do this in certain instances, you can do something like the following to only apply this to * categories.
* if ( ! is_category ){
* return $title;
* }
*
*/
$title = ucwords( $title );
return $title;
}

@wpsmort
Copy link
Author

wpsmort commented Aug 1, 2017

This is tested and is good.

@wpsmort wpsmort closed this as completed Aug 1, 2017
@wpsmort wpsmort removed their assignment Aug 2, 2017
michaeltorbert pushed a commit that referenced this issue Sep 6, 2017
…horten long description

#951 Fixes wrong string counts due to HTML entities and #1022 never shorten long description

* remove category capitalization from get_tax_name function #530

* remove tag and search capitalization of titles #560

* #951 Fixes wrong string counts due to HTML entities

Fixes wrong title/description length counts that were being generated
due to HTML entities not being decoded.
#951 Fixes wrong string counts due to HTML entities and #1022 never shorten long description

* #951 Refactored truncation execution order

Refactored the way the description was being truncated or cropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants