Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACF macro is being output in titles and meta descriptions #959

Closed
wpsmort opened this Issue Jul 13, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@wpsmort
Copy link
Member

wpsmort commented Jul 13, 2017

When you use the ACF macro (https://semperplugins.com/documentation/advanced-custom-fields-integration-with-title-format-fields/) in the Title Format field or Description Format field then we output the macro when the custom field is empty.

For example, if you have an ACF custom field called short_description and you use the macro %cf_short_description% in either the Title Format field or Description format field then you get this result when the field is empty on any post:

<title>%cf_short_description% | My Test Site</title>
<meta name="description"  content="%cf_short_description%" />

This also affects OG and Twitter meta tags as well.

@wpsmort wpsmort added the Bug label Jul 13, 2017

@wpsmort wpsmort added this to the 2.3.15 milestone Jul 13, 2017

@wpsmort wpsmort modified the milestones: 2.3.15, 2.3.16, 2.3.17 Aug 3, 2017

@wpsmort wpsmort modified the milestones: 2.3.17, 2.5 Sep 5, 2017

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Jan 17, 2018

@contactashish13

This comment has been minimized.

Copy link
Contributor

contactashish13 commented Jan 17, 2018

PR: #1488

@wpsmort

This comment has been minimized.

Copy link
Member Author

wpsmort commented Feb 12, 2018

This is tested and is good.

@wpsmort wpsmort assigned michaeltorbert and unassigned wpsmort Feb 13, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 6, 2018

contactashish13 added a commit to contactashish13/all-in-one-seo-pack that referenced this issue Mar 6, 2018

@michaeltorbert michaeltorbert removed their assignment Mar 19, 2018

michaeltorbert added a commit that referenced this issue Mar 19, 2018

ACF macro is being output in titles and meta descriptions (#1488)
* ACF macro is being output in titles and meta descriptions #959

* test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.