Single apostrophe is changed to two in Doc title

[michaeltorbert]

Reported here: https://wordpress.org/support/topic/july-update-adding-an-extra-to-my-title/ to have broken in 2.3.14

[wpsmort]

@michaeltorbert @amostajo I was able to reproduce this on a brand new site. The problem is with the %blog_title% part of the title tag. To reproduce this follow these steps:

• Set up a site where the Site Title has an apostrophe, i.e Steve's Test Site
• Activate AIOSEOP v2.3.14 with default config
• Visit any page or post on the site and look at the browser tab, you should see the two apostrophes, see screenshot below

I tested this with all versions of PHP from 5.2 to 7.1 and got the same result.

[michaeltorbert]

In my testing I just left everything blank but put Michael's site in the site title in WordPress General Settings (not AIOSEOP settings) and it showed up as a quotation mark.

[michaeltorbert]

The problem is that ' (which is a single apostrophe) is being checked for in aioseop_class.php:4913

[amostajo]

@michaeltorbert The change is partially fine. But we might need to include the charcode conversion in the preg_replace to support PHP5.2.

See this commit on my fork.