/simplemap

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually entered coordinates get changed on save #117

Closed
wpsmort opened this Issue Nov 8, 2016 · 3 comments

Comments

Assignees

@wpsmort wpsmort

Labels
Bug Priority - High
Projects
None yet
Milestone
  2.6
3 participants
@wpsmort @michaeltorbert @stanislavsa
@wpsmort
Copy link
Member

wpsmort commented Nov 8, 2016

First reported here - http://support.simplemap-plugin.com/discussions/problems/2600-issue-with-longlat-entry

When you manually enter the coordinates in a location then the coordinates get changed upon updating the post.

Tested with these coordinates - 38.946057 / -91.9390670

@wpsmort wpsmort added Bug Priority - High labels Nov 8, 2016

@wpsmort wpsmort assigned michaeltorbert Nov 8, 2016

@michaeltorbert michaeltorbert assigned stanislavsa and unassigned michaeltorbert Mar 21, 2017

@michaeltorbert michaeltorbert added this to the 2.5.1 milestone Mar 21, 2017

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Mar 21, 2017

@stanislavsa
semperfiwebdesign#117 Manually entered coordinates get changed on save
9d7ce6d
@wpsmort

This comment has been minimized.

Sign in to view
Copy link
Member Author

wpsmort commented Mar 22, 2017

@stanislavsa: Were you able to replicate this bug before you made your code changes? If so, how did you replicate it. I've been unable to replicate the initial bug. With version 2.4.10.1 I was able to change coordinates and they would save.

@michaeltorbert michaeltorbert referenced this issue Mar 22, 2017

Merged

#117 Manually entered coordinates get changed on save #206

michaeltorbert added a commit that referenced this issue Mar 22, 2017

@stanislavsa @michaeltorbert
#117 Manually entered coordinates get changed on save (#206)
5701061

@michaeltorbert michaeltorbert assigned michaeltorbert and unassigned stanislavsa Mar 22, 2017

@michaeltorbert michaeltorbert added Needs Code Review Needs Testing and removed Needs Code Review labels Mar 22, 2017

@michaeltorbert michaeltorbert assigned wpsmort and unassigned michaeltorbert Mar 22, 2017

@michaeltorbert

This comment has been minimized.

Sign in to view
Copy link
Member

michaeltorbert commented Mar 22, 2017

Looks good to me.
@wpsmort

This comment has been minimized.

Sign in to view
Copy link
Member Author

wpsmort commented Mar 22, 2017

This is tested and is good. I tested with these coordinates - 38.946057 / -91.9390670

@wpsmort wpsmort closed this Mar 22, 2017

@wpsmort wpsmort removed the Needs Testing label Mar 22, 2017

@wpsmort wpsmort modified the milestones: 2.6, 2.5.1 Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment