New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SimpleMap search form from tables to divs #179

Closed
wpsmort opened this Issue Mar 1, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@wpsmort
Copy link
Member

wpsmort commented Mar 1, 2017

Currently the search form is contained in an HTML table which is old and not great for theming or for responsiveness. We need to convert this to divs but make sure we continue to support all the same shortcode attributes such as number of columns, empty cells, etc.

@wpsmort wpsmort added the Enhancement label Mar 1, 2017

@wpsmort wpsmort self-assigned this Mar 1, 2017

@michaeltorbert michaeltorbert assigned EkoJR and unassigned wpsmort Mar 19, 2017

EkoJR added a commit to EkoJR/simplemap that referenced this issue Mar 20, 2017

@michaeltorbert michaeltorbert added this to the 2.5.1 milestone Mar 21, 2017

@wpsmort

This comment has been minimized.

Copy link
Member Author

wpsmort commented Mar 21, 2017

I have tested this with the standard shortcode and with various shortcode attributes including the columns attribute with 1 through to 5 columns. This works fine except that some users may need to add a display:none; to the empty cell divs that have a class of .location_search_empty_cell.location_search_cell. This will depend on how the user has implemented the shortcode attributes to create their columns.

Other than this, the new divs work well.

@wpsmort wpsmort closed this Mar 21, 2017

michaeltorbert added a commit that referenced this issue Mar 22, 2017

Convert SimpleMap search form from tables to divs for #179 (#207)
* Changed Search Form Table to Dividers #179

* Fixed div to display as a table block

Preserves the original format of a table.

* Adding fix to display responsive tables

* Added width to divider cells based on number of columns

* Clean up

* Added additional resposive cells before finalizing

* Adding CSS Notes to div table layout.
@wpsmort

This comment has been minimized.

Copy link
Member Author

wpsmort commented Mar 23, 2017

I've copied the styles from the Light theme to the Dark theme just in case we don't remove the Dark theme this version.

I've tested again with both themes and everything is good.

@wpsmort wpsmort closed this Mar 23, 2017

@wpsmort wpsmort modified the milestones: 2.6, 2.5.1 Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment