New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for searching by location name #19

Closed
arnaudbroes opened this Issue Apr 15, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@arnaudbroes
Copy link
Collaborator

arnaudbroes commented Apr 15, 2016

Added field for searching by name.

This should enable a user to search for the location name (i.e. the title of the location post).

@wpsmort

This comment has been minimized.

Copy link
Member

wpsmort commented Jun 15, 2016

This should bee in the code for SimpleMap v2.5

@wpsmort wpsmort assigned stanislavsa and unassigned michaeltorbert Apr 4, 2017

@wpsmort wpsmort added this to the 2.6 milestone Apr 4, 2017

@wpsmort wpsmort changed the title Add field for searching by name / description Add field for searching by name Apr 4, 2017

@wpsmort wpsmort changed the title Add field for searching by name Add field for searching by location name Apr 4, 2017

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Apr 10, 2017

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Apr 10, 2017

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Apr 10, 2017

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Apr 10, 2017

@wpsmort

This comment has been minimized.

Copy link
Member

wpsmort commented Apr 17, 2017

@stanislavsa I tested this but found that if you entered a pace name, a ZIP code and selected a distance that it would ignore the distance. It also seemed to be matching on category and tag names. So I could enter the name of a category in the place field and it would return locations in that category.

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Apr 18, 2017

@stanislavsa stanislavsa referenced this issue Apr 18, 2017

Closed

Issue #19 #241

@stanislavsa

This comment has been minimized.

Copy link
Contributor

stanislavsa commented Apr 18, 2017

The distance ignoring issue fixed.
Matching on category and tag names is in progress.

@wpsmort

This comment has been minimized.

Copy link
Member

wpsmort commented Apr 18, 2017

@stanislavsa I tested PR #241 and found that the behavior is now worse than before. When I search for a place name with a ZIP code that has that location in then nothing is returned and the map jumps to a random place somewhere else.

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Apr 18, 2017

@stanislavsa

This comment has been minimized.

Copy link
Contributor

stanislavsa commented Apr 18, 2017

@wpsmort In earlier commit I added place name data to the 'address' parameter in the geocoder js function and in some cases it returns wrong results (latitude and longitude). So I removed that code.

stanislavsa added a commit to stanislavsa/simplemap that referenced this issue Apr 19, 2017

@wpsmort

This comment has been minimized.

Copy link
Member

wpsmort commented Apr 25, 2017

This is tested and works fine. This is now ready for code review.

@michaeltorbert michaeltorbert referenced this issue May 1, 2017

Merged

Issue #19 #242

michaeltorbert added a commit that referenced this issue May 1, 2017

Add field for searching by location name Issue #19 (PR #242)
* Add field for searching by location name #19

* field for searching by location name #19 - space fix

* field for searching by location name #19 - case comparison fix

* field for searching by location name #19 - check if location name is empty

* field for searching by location name #19 - fixed distance ignoring issue

* field for searching by location name #19 - remove place name data from geocoder function

* #19 - added searching by tags and categories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment