New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations are no longer geocoded when inserted #277

Closed
wpsmort opened this Issue Oct 19, 2018 · 11 comments

Comments

Projects
None yet
4 participants
@wpsmort
Copy link
Member

wpsmort commented Oct 19, 2018

Reported by Marco S. by email on 10/18/2018.

When you import locations into SimpleMap using the CSV file, locations should get geocode (longitude and latitude added) upon import. However, when you edit an imported location the longitude and latitude fields are empty.

@wpsmort

This comment has been minimized.

@wpsmort

This comment has been minimized.

Copy link
Member Author

wpsmort commented Oct 22, 2018

Reported again by Adam T. by email.

@arnaudbroes

This comment has been minimized.

Copy link
Collaborator

arnaudbroes commented Oct 30, 2018

Reported again by James B. by e-mail.

@arnaudbroes

This comment has been minimized.

Copy link
Collaborator

arnaudbroes commented Oct 30, 2018

Here's what Ben said so far:

It's looking like is an issue with the missing Country param.

I've tried a few workarounds with no success. Even if the fallback was the default country, it is still problematic if the address does reside in the country. Plus, Google requires that country param.

@wpsmort

This comment has been minimized.

@arnaudbroes arnaudbroes changed the title Locations are no longer geocoded upon import Locations are no longer geocoded when inserted Jan 17, 2019

@arnaudbroes

This comment has been minimized.

Copy link
Collaborator

arnaudbroes commented Jan 17, 2019

This also happens when adding a new location through the backend, so it's a general issue, and not specific to the importer/exporter.

@arnaudbroes

This comment has been minimized.

Copy link
Collaborator

arnaudbroes commented Jan 25, 2019

This now broke completely. I'm going to try and debug this in PHPStorm, but I've also contacted Google to see if they did any recent changes to the Geocode API.

@wpsmort

This comment has been minimized.

Copy link
Member Author

wpsmort commented Jan 26, 2019

Reported by Bob Thornton by email

arnaudbroes added a commit to arnaudbroes/simplemap that referenced this issue Jan 28, 2019

arnaudbroes added a commit to arnaudbroes/simplemap that referenced this issue Jan 28, 2019

arnaudbroes added a commit to arnaudbroes/simplemap that referenced this issue Jan 28, 2019

@arnaudbroes

This comment has been minimized.

Copy link
Collaborator

arnaudbroes commented Jan 28, 2019

This issue has two causes:

  1. The API request now has to be done over HTTPS; and the current scheme is HTTP.
  2. The API request requires an API key, which it lacks at the moment.

@arnaudbroes arnaudbroes assigned arnaudbroes and unassigned EkoJR Jan 28, 2019

@wpsmort wpsmort added this to the 2.5.1 milestone Jan 29, 2019

@wpsmort

This comment has been minimized.

Copy link
Member Author

wpsmort commented Jan 29, 2019

@arnaudbroes Can you look and see if you can fix the geocoding of locations on import as that is part of this issue.

@arnaudbroes

This comment has been minimized.

Copy link
Collaborator

arnaudbroes commented Jan 30, 2019

@wpsmort it does not; only after updating each location. I'll check where the API call is happening and fix it.

arnaudbroes added a commit to arnaudbroes/simplemap that referenced this issue Jan 30, 2019

arnaudbroes added a commit to arnaudbroes/simplemap that referenced this issue Jan 30, 2019

michaeltorbert added a commit that referenced this issue Feb 8, 2019

Merge pull request #281 from arnaudbroes/#277
Fix geocoding for locations

@michaeltorbert michaeltorbert modified the milestones: 2.5.1, 2.6 Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment