This repository has been archived by the owner. It is now read-only.

Fixed switch-to-frame to use the native (java) frame object instead of the clojure wrapper #56

Closed
wants to merge 1 commit into
from

Conversation

2 participants

No description provided.

Owner

semperos commented May 31, 2012

Not sure what :webframe is referring to there. Could you explain what you're trying to accomplish in more detail?

I use switch-to-frame in my code and it does not work without this patch.

The reason is that RemoteWebDriver.RemoteTargetLocator expects WebElement (see http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/WebDriver.TargetLocator.html)

The frame parameter passed into switch-to-frame is a clojure map that has WebElement in the :webframe key.

I use it in the following way: "(switch-to-frame {:tag :frame :name "main"})". Is it wrong?

The documentation gives the following example of usage: "(switch-to-frame "#target-frame")"

May be the better way would be to implement it like switch-to-window. By changing clj-webdriver.taxi/switch-to-frame to not wrap the frame-q into Element and clj-webdriver.core to contain cond.

Owner

semperos commented Oct 4, 2012

Sorry I've taken so long to get into this, I don't often touch the frame-handling code.

I've fixed frame handling in the master branch for both the Core and Taxi API's, I suggest you look there for conformant code until I cut the next release (should be very soon).

I'm closing this out, but am still confused by your usage of :webframe, as that doesn't exist anywhere in the clj-webdriver API.

@semperos semperos closed this Oct 4, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.