Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix taxi/elements to always return a list of elements, even when its argument is an element #93

Merged
merged 2 commits into from

2 participants

@marshallbrekka

This allows quick-fill to be passed elements directly instead of selector strings.

@semperos
Owner

Thanks for the pull request!

I know it's only a single item in that branch of the if, but the default *finder-fn* will return a lazy seq. I'd like not to have one branch of this if return a linked list and the other a lazy seq, so if you'd make that match I'd be happy to accept this. It's definitely a mistake on my part that it returns a single item instead of a sequence of items.

@marshallbrekka

Matched :+1:

@semperos semperos merged commit 8ba9424 into from
@semperos
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 31, 2013
  1. @marshallbrekka
Commits on Feb 1, 2013
  1. @marshallbrekka

    return lazy seq

    marshallbrekka authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/clj_webdriver/taxi.clj
View
2  src/clj_webdriver/taxi.clj
@@ -230,7 +230,7 @@
([q] (elements *driver* q))
([driver q]
(if (element-like? q)
- q
+ (lazy-seq (list q))
(*finder-fn* driver q))))
;; ## Driver functions ##
Something went wrong with that request. Please try again.