Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magazine Layout: Adsense involved - from Magazine to Blog Layout #80

Closed
ghost opened this issue Sep 9, 2017 · 9 comments
Closed

Magazine Layout: Adsense involved - from Magazine to Blog Layout #80

ghost opened this issue Sep 9, 2017 · 9 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Sep 9, 2017

Hello Develoeprs,

I can unfortunately observe the following at the magazine theme.

If I enter the Adsense code in the field provided for this purpose, the magazine layout automatically changes to the blog layout.

All magazine changes are then no longer valid and a blog layout.

I currently have PHP 5.6.

Can you please check this with the new magazine Theme.

Thanks in advance.

@semplon
Copy link
Collaborator

semplon commented Sep 9, 2017

@AlexL777 ok, sure. i'll check it

@semplon
Copy link
Collaborator

semplon commented Sep 9, 2017

i've already know the problem is. i'll commit it soon and see other bugs exist. if not i'll release the next update,

@semplon semplon self-assigned this Sep 9, 2017
@semplon semplon added the bug label Sep 9, 2017
@ghost
Copy link
Author

ghost commented Sep 9, 2017

Okay, then we'll do it. Yes, I know, some bugs are still available. But I have simply patience, rather everything was fixed.

For now, my Genix blog works with the blog layout. SEO URLs also work. Then I have defined in the style.css the headings differently. I felt like the H2 headings were not displayed in the frontend.

A look into the style.css was however positive. H2 CSS rule was included. Nevertheless, I have defined something different. This already works.

Thank you for your time.

@semplon
Copy link
Collaborator

semplon commented Sep 9, 2017

actually you can fix it by following this step :

  • open options.php at the gneex theme directory

  • go to line 45, and replace this code
    $opt[$k] = Typo::jsonFormat($v);
    become
    $opt[$k] = $v;

  • and save it.

let me know if it works.

actually there are a lot of features for the 1.1.0 release. the problem was my laptop which had the latest update stolen and i had to rebuild again from last 1.1.0 update. one of the update was cached page. this is really good for non dynamic website and to make website load fast.

i will implement this on the next future update.

@ghost
Copy link
Author

ghost commented Sep 9, 2017

Ok, awesome. Your tips helped and I was able to integrate successful Adsense into the blog. This is now displayed via 3 Adsense banners in the frontend.

Think, so my problem is solved 👍

@semplon
Copy link
Collaborator

semplon commented Sep 9, 2017

cool, glad it works

@ghost
Copy link
Author

ghost commented Sep 9, 2017

😄

@semplon
Copy link
Collaborator

semplon commented Sep 10, 2017

Hi @AlexL777 , for H2 please change it here http://prntscr.com/gjcgu5
it's at theme options -> style
see the Content part

slide the Content Title Single Size

@ghost
Copy link
Author

ghost commented Sep 10, 2017

Thank you, I looked at something, but only briefly flown. Now I know where the backend is.

semplon pushed a commit that referenced this issue Sep 11, 2017
Security and Bug Fix
Version 1.1.1
@semplon semplon closed this as completed Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant