From 229ba89feb9fee785905b9dc0edd6fda1b659679 Mon Sep 17 00:00:00 2001 From: Mikhail Sereniti Date: Thu, 27 Jun 2024 13:50:23 +0200 Subject: [PATCH] [notice] removed critical notification label from notice with warning theme --- semcore/notice/CHANGELOG.md | 6 ++++++ semcore/notice/src/Notice.jsx | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/semcore/notice/CHANGELOG.md b/semcore/notice/CHANGELOG.md index 1c6bc5e17..91ba00c58 100644 --- a/semcore/notice/CHANGELOG.md +++ b/semcore/notice/CHANGELOG.md @@ -2,6 +2,12 @@ CHANGELOG.md standards are inspired by [keepachangelog.com](https://keepachangelog.com/en/1.0.0/). +## [5.35.1] - 2024-06-27 + +### Fixed + +- Notice only with `danger` theme has aria-label "Critical Notification" (`warning` theme gets "Notification" as all other themes). + ## [5.35.0] - 2024-06-19 ### Changed diff --git a/semcore/notice/src/Notice.jsx b/semcore/notice/src/Notice.jsx index 68f885231..535675452 100644 --- a/semcore/notice/src/Notice.jsx +++ b/semcore/notice/src/Notice.jsx @@ -76,7 +76,7 @@ class RootNotice extends Component { backgroundColor={color} role='region' aria-live={ariaLive} - aria-label={getI18nText(isAssertive ? 'criticalNotification' : 'notification')} + aria-label={getI18nText(theme === 'danger' ? 'criticalNotification' : 'notification')} > ,