Bug fix for bug stated here: http://groups.google.com/group/arc-dev/browse_thread/thread/410becee0f1aa205/53cb84bab6a0b283#53cb84bab6a0b283 #5

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Knurg commented Mar 4, 2011

Hi,

this contains a bugfix for a wrong regular expression.
Upon doing some more research we found the source of the problem.

Line 619 and 620 of ARC2_StoreSelectQueryHandler:
$deps[$id]['rank'] += ($id != $other_id) && preg_match('/' .
$other_id . '/', $code) ? 1 : 0;
$deps[$id][$other_id] = ($id != $other_id) && preg_match('/' .
$other_id . '/', $code) ? 1 : 0;
The preg_match must be:
$deps[$id]['rank'] += ($id != $other_id) && preg_match('/' .
$other_id . '\D/', $code) ? 1 : 0;
$deps[$id][$other_id] = ($id != $other_id) && preg_match('/' .
$other_id . '\D/', $code) ? 1 : 0;
because otherwise T_0_0_1 matches T_0_0_10 or T_0_0_13 although there
is no connection between them.

Therefore arc2 always told us it could not resolve all dependencies as T_0_0_1 was always found if any T above 9 was in the dependencies.

Sincerely,

Mark

Contributor

CloCkWeRX commented Mar 22, 2012

@Knurg - what's the go with this one? It's a much smaller pull request than #9 and worth doing in isolation perhaps?

Knurg commented Mar 22, 2012

Probably - that was the point in opening it separately at that time.

@Knurg Knurg referenced this pull request May 23, 2013

Open

Fixed severe bugs #9

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment