Cache allowed transitions for analyses on the request #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the rendering performance of worksheets containing a huge amount of analyses with dependencies.
xispa
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This improves the rendering performance of worksheets containing a huge
amount of analyses with dependencies.
Current behavior before PR
The guard
guard_retractof worksheets checks for all contained analyses if the "retract" transition is allowed. This code fetches all dependencies of each analysis, which causes the same analyses to be checked multiple times.Example:
A worksheet containing 434 Analyses with dependencies takes
326.86sto renderDesired behavior after PR is merged
Checked analyses cache their value on the request, so that these analyses are skipped.
In the example above this improves rendering speed by a factor
≈5,65to57.86s--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.