Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

use supertest and don't expose .proto #1021

Closed
jonathanong opened this Issue Mar 8, 2014 · 6 comments

Comments

Projects
None yet
2 participants
Contributor

jonathanong commented Mar 8, 2014

tried doing so, but the tests are messed up due to all the tests with the encoding. supertest encodes the URI before making the request, making the tests useless.

would also like to no longer expose the proto.

not like this really matters anymore anyways...

Contributor

dougwilson commented Mar 8, 2014

I was just trying to convert the tests to supertest the other day and was having the same issue. I think I may have a solution, though, and will update here :)

Contributor

dougwilson commented Mar 8, 2014

What would be the main reason why we cannot remove connect.proto?

Contributor

jonathanong commented Mar 8, 2014

not 100% sure, but i think the current tests use app.request(), which works off connect.proto.

Contributor

dougwilson commented Mar 8, 2014

Right, but besides the tests needing it, is there any other reason? :) As in, if I am able to change the tests to use supertest, can I remove connect.proto export as well?

Contributor

jonathanong commented Mar 8, 2014

yes please!

@dougwilson dougwilson self-assigned this Mar 8, 2014

Contributor

dougwilson commented Apr 30, 2014

The proto export is removed in 177b18f for 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment