Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make "leading slash" optional in req.url #381

Closed
adammw opened this Issue Sep 28, 2011 · 0 comments

Comments

Projects
None yet
2 participants
Contributor

adammw commented Sep 28, 2011

Connect (in http.js) ensures a leading slash in req.url, making it impossible to differentiate between, for example, http://something/foobar and /http://something/foobar . This is needed in a scenario where Connect is acting as a HTTP proxy tunnel rather than a standard http server. An easy fix would be commenting out line191 in http.js but then that would cause lots of problems for the primary use case of a http server. Connect doesn't seem to really have any way to get options into a HTTP server (unlike HTTPS servers, which have an options parameter), so there needs to be a way to allow the make leading slash code to be optional, perhaps server.set(option, value), or allow the first parameter of createServer to be options for HTTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment