Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Session test failing on master #388

Closed
ryanrolds opened this Issue Oct 2, 2011 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

ryanrolds commented Oct 2, 2011

ryan@blah:~/repos/connect$ ./node_modules/.bin/expresso -I lib test/session.test.js
Error: connect.cookieParser("secret") required for security when using sessions
    at Object.session [as handle] (/home/ryan/repos/connect/lib/middleware/session.js:217:28)
    at next (/home/ryan/repos/connect/lib/proto.js:172:15)
    at Object.cookieParser [as handle] (/home/ryan/repos/connect/lib/middleware/cookieParser.js:55:5)
    at next (/home/ryan/repos/connect/lib/proto.js:172:15)
    at Function.handle (/home/ryan/repos/connect/lib/proto.js:185:3)
    at Server.app (/home/ryan/repos/connect/lib/connect.js:53:31)
    at Server.emit (events.js:67:17)
    at HTTPParser.onIncoming (http.js:1134:12)
    at HTTPParser.onHeadersComplete (http.js:108:31)
    at Socket.ondata (http.js:1029:22)

   uncaught: TypeError: Cannot read property '0' of undefined
    at expires (/home/ryan/repos/connect/test/session.test.js:41:35)
    at /home/ryan/repos/connect/test/session.test.js:203:28
    at IncomingMessage.<anonymous> (/home/ryan/repos/connect/node_modules/expresso/bin/expresso:479:17)
    at IncomingMessage.emit (events.js:81:20)
    at HTTPParser.onMessageComplete (http.js:133:23)
    at Client.onData [as ondata] (http.js:1488:27)
    at Client._onReadable (net.js:677:27)
    at IOWatcher.onReadable [as callback] (net.js:177:10)


   uncaught: TypeError: Cannot read property 'should' of undefined
    at /home/ryan/repos/connect/test/session.test.js:637:15
    at /home/ryan/repos/connect/lib/middleware/session/store.js:61:23
    at Array.<anonymous> (/home/ryan/repos/connect/lib/middleware/session/memory.js:57:7)
    at EventEmitter._tickCallback (node.js:126:26)


   uncaught: AssertionError: expected 'RGVkT3dBT0c2R1ZNWHI5VlRScWxkc0Zk.rHTcgeBd7TWchpzcttCmoq%2BVpHg' to not equal 'RGVkT3dBT0c2R1ZNWHI5VlRScWxkc0Zk.rHTcgeBd7TWchpzcttCmoq%2BVpHg'
    at Object.equal (/home/ryan/repos/connect/node_modules/should/lib/should.js:306:10)
    at /home/ryan/repos/connect/test/session.test.js:666:25
    at IncomingMessage.<anonymous> (/home/ryan/repos/connect/node_modules/expresso/bin/expresso:479:17)
    at IncomingMessage.emit (events.js:81:20)
    at HTTPParser.onMessageComplete (http.js:133:23)
    at Client.onData [as ondata] (http.js:1488:27)
    at Client._onReadable (net.js:677:27)
    at IOWatcher.onReadable [as callback] (net.js:177:10)
Member

tj commented Oct 2, 2011

sorry about that :) I have to update the tests still, I've been migrating signed cookies to cookieParser()

on a side node make test TESTS=test/whatever.js works as well

Contributor

ryanrolds commented Oct 2, 2011

Awesome, that is much shorter.

Member

tj commented Oct 2, 2011

yup :D i'll get those tests fixed up pretty soon here

Contributor

ryanrolds commented Oct 2, 2011

Cool. Now to find something to work on. ;)

@ryanrolds ryanrolds closed this Oct 2, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment