Licensing issue: Change 'crc' dependecy to 'buffer-crc32' #712

Closed
mdp opened this Issue Dec 18, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@mdp
Contributor

mdp commented Dec 18, 2012

Connect depends on the node module 'crc' (https://github.com/alexgorbatchev/node-crc) which has licensing issues (alexgorbatchev/node-crc#2)

Express moved to https://github.com/brianloveswords/buffer-crc32 to solve this issue.

@mdp

This comment has been minimized.

Show comment
Hide comment
@mdp

mdp Dec 18, 2012

Contributor

Ignore, I just realized that connect is using crc16, which doesn't have a MIT/BSD licensed alternative.

Contributor

mdp commented Dec 18, 2012

Ignore, I just realized that connect is using crc16, which doesn't have a MIT/BSD licensed alternative.

@mdp mdp closed this Dec 18, 2012

@tj

This comment has been minimized.

Show comment
Hide comment
@tj

tj Dec 20, 2012

Member

the perf is probably negligible between 16/32, we could probably switch to the same lib express is using even though the payloads are a lot smaller

Member

tj commented Dec 20, 2012

the perf is probably negligible between 16/32, we could probably switch to the same lib express is using even though the payloads are a lot smaller

mdp added a commit to mdp/connect that referenced this issue Dec 21, 2012

Replace 'node-crc' with 'buffer-crc32', fixes licensing
The 'crc' package is using code that is not freely licensed(MIT/BSD)
alexgorbatchev/node-crc#2

Express also moved to 'buffer-crc32' recently because of this issue.

Fixes senchalabs/connect#712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment