Skip to content

Loading…

Licensing issue: Change 'crc' dependecy to 'buffer-crc32' #712

Closed
mdp opened this Issue · 2 comments

2 participants

@mdp

Connect depends on the node module 'crc' (https://github.com/alexgorbatchev/node-crc) which has licensing issues (alexgorbatchev/node-crc#2)

Express moved to https://github.com/brianloveswords/buffer-crc32 to solve this issue.

@mdp

Ignore, I just realized that connect is using crc16, which doesn't have a MIT/BSD licensed alternative.

@mdp mdp closed this
@tj
Sencha Labs member
tj commented

the perf is probably negligible between 16/32, we could probably switch to the same lib express is using even though the payloads are a lot smaller

@mdp mdp added a commit to mdp/connect that referenced this issue
@mdp mdp Replace 'node-crc' with 'buffer-crc32', fixes licensing
The 'crc' package is using code that is not freely licensed(MIT/BSD)
alexgorbatchev/node-crc#2

Express also moved to 'buffer-crc32' recently because of this issue.

Fixes senchalabs/connect#712
fe6ba40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.