headers, conditional range requests, tests #386

Merged
merged 1 commit into from Oct 2, 2011

Projects

None yet

2 participants

@ryanrolds
Contributor

Fixed a couple issue with important headers not being sent, may be going overboard now.
Date wasn't not being sent with range requests
Added Content-Length to range requests
Conditional requests with a range should return 304 if the conditions are false (RFC 2616 14.35.2)
Added a test for conditional ranges
Fixed what appeared to be a problems with some of the range tests

@tj
Member
tj commented Oct 2, 2011

looks good thanks for the tests!

@tj tj merged commit 755eb26 into senchalabs:master Oct 2, 2011
@tj
Member
tj commented Oct 2, 2011

havent looked into it yet but the backport of this has one failing range test

@ryanrolds
Contributor

I just ran the tests in 1.x and they completed fine. I assume that is what you mean.

@tj
Member
tj commented Oct 3, 2011

hmm strange

@ryanrolds
Contributor

What is the message you're getting?

@tj
Member
tj commented Oct 3, 2011

uncaught: AssertionError: test with wildcard. Invalid response status code.
Expected: 304
Got: 206

expresso gets the title wrong since it's an async exceptions haha.. no way around that unfortunately since they are all parallel but with the status codes you can see it's a range one. I'll have a look after work since it's only mine failing

@ryanrolds
Contributor

Sounds good. I will triple check my copy and make sure I'm not missing something.

@ryanrolds
Contributor

I just triple checked. Tests runs fine in master and 1.x. Are you using a version of Node earlier then 0.4.12?

@tj
Member
tj commented Oct 4, 2011

hmm nope 0.4.12 as well, i'll look into it when i have some time

@ryanrolds
Contributor

Shot in the dark.

ejs@0.4.3
expresso@0.7.6
koala@0.1.2
less@1.1.1
markdown@0.2.1
mime@1.2.4
qs@0.3.1
sass@0.5.0
should@0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment