Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove req._logging at the end of logger() function so you could use two #405

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

pacovell commented Nov 4, 2011

Remove req._logging at the end of logger() function so you could use two logger helpers, for example one to log to stdout and one to a file.

Paul Covell Remove req._logging at the end of logger() function so you could use …
…two logger helpers, for example one to log to stdout and one to a file.
f07c6f0
Member

tj commented Nov 4, 2011

im not sure I understand what you're doing with this. If you want to log to a file and stdio why not just use tee(1)? or pass a { stream: object } and have that object's write() implementation log to as many other streams as you want

One example which needs multiple log output is access/error logs which can be determined by status code. I implemented my own logger middleware.

Contributor

dylanahsmith commented Mar 10, 2013

Fixed by commit 053d6f6 for version >= 2.3.5, so this can be closed now.

@tj tj closed this Mar 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment