`createServer()` should accept middleware. #520

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@stephank

createServer used to accept middleware, to be mounted at /. In fact, a lot of the included examples try to use this functionality, but are right now broken.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj Mar 28, 2012

Member

In 2.x we can break a few little things like this, it was a bad idea from the beginning, you can't manipulate it progressively and you have no access to mounting so it's inevitable that you'll have to break it out into .use() calls at some point

Member

tj commented Mar 28, 2012

In 2.x we can break a few little things like this, it was a bad idea from the beginning, you can't manipulate it progressively and you have no access to mounting so it's inevitable that you'll have to break it out into .use() calls at some point

@stephank

This comment has been minimized.

Show comment Hide comment
@stephank

stephank Mar 28, 2012

I concur, but then, should the examples be fixed instead? I'm thinking there's no real loss in accepting middleware in createServer, and we keep a small bit of backwards compat.

I concur, but then, should the examples be fixed instead? I'm thinking there's no real loss in accepting middleware in createServer, and we keep a small bit of backwards compat.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj Mar 28, 2012

Member

yup they definitely need updates, i only had time to update the session ones since i was testing stuff anyway

Member

tj commented Mar 28, 2012

yup they definitely need updates, i only had time to update the session ones since i was testing stuff anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment