Skip to content

Set session cookie only when the cookie is updated #569

Closed
wants to merge 2 commits into from

1 participant

@eknkc
eknkc commented May 17, 2012

Hey, took the liberty to change some stuff in session tests and added cookie hash function. Check if it is ok..

  • New hash function only uses cookie data to compute hash.
  • isNew check added to ensure that a new session gets a cookie.
  • Updated tests
    • should only set-cookie when modified for the topic itself
    • I also renamed sid helper function to signedSid as it's the bare cookie including sha256 signature and replaced sid with one that actually parses session ID itself to avoid confusion.
    • Made modifications to tests using sid to use signedSid

Fixes Issue #568

@eknkc
eknkc commented May 17, 2012

This requires some work. Gonna take a deeper look and reopen.

@eknkc eknkc closed this May 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.